Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#5859 closed defect (fixed)

Numerous small build issues on msvc

Reported by: nickm Owned by:
Priority: Medium Milestone: Tor: 0.2.3.x-final
Component: Core Tor/Tor Version:
Severity: Keywords: tor-client
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

aes.c doesn't build because the openssl headers freak out if you don't include winsock2 right first.

buffers.c uses "inline", when we only have the right magic to make "INLINE" work.

MSVC doesn't accept that tor_assert(0) can never return, and so complains about functions that should return values but don't.

MSVC warns if you declare a function as having a "int foo" argument and then implement it with a "const int foo" argument, even though the latter "const" is not a part of the function's interface.

Child Tickets

Change History (3)

comment:1 Changed 8 years ago by nickm

Resolution: fixed
Status: newclosed

Fixed in 7134be0637, 757725ffdef0aa64a5a4, 43e15300bad6dd2618, d8de831932cefe2f, and ee1b8196d372a1a407.

comment:2 Changed 8 years ago by nickm

Keywords: tor-client added

comment:3 Changed 8 years ago by nickm

Component: Tor ClientTor
Note: See TracTickets for help on using tickets.