Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#5863 closed enhancement (fixed)

Remove the ability to toggle Torbutton

Reported by: mikeperry Owned by: mikeperry
Priority: Very High Milestone:
Component: Applications/Torbutton Version:
Severity: Keywords: MikePerry201205
Cc: proper@… Actual Points: 1
Parent ID: Points: 1
Reviewer: Sponsor:

Description

Torbutton has long since become unsafe to use in a toggle capacity due to the change in our plugin handling code for #3580, and probably due to new Firefox features like WebThreads. We've wanted to do a release that warns users not to use it if we don't detect Tor Browser underneath us (#3838), but I feel guilty doing that without an autoupdater for Tor Browser and with the lack of the ability to ensure build integrity (#3688 or at the very least #5837).

However, if we disable the ability toggle entirely (and also disable a couple other things - #5758), it *might* not be the end of the world if you still insist on using Torbutton in Vanilla firefox. You'll stick out like a sore thumb and be way more linkable across different websites, but at least the proxy probably won't be bypassed.

We should probably also do a less harsh form of #3838 in a popup suggesting TBB as part of this, I guess. Maybe. I'd still like us to get started on #5837 somehow, at least.

Child Tickets

Change History (3)

comment:1 Changed 8 years ago by proper

Cc: proper@… added

I vote for completely removing the toggle functionality.

You could simplify and shrink the code.

No more testing required for tests in non-tor mode.

Tor Button settings dialog would get gets smaller, easier to understand.

It's also a design goal, that Tor Button also shall not reveal the fact, that you are a Tor user, while you are not using Tor (toogle to non-Tor). As there are Firefox patches during Tor mode, do you disable them during non-Tor mode and could them be used to detect, that someone is not a Tor user?

You also could get ride of Toogle Model Bugs. I think your time is better spend in fixing more important stuff than less important, unfinished features barely anyone uses.

Who still uses the toggle function anyway? You may ask your users if they are adamant about keeping the feature.

comment:2 Changed 8 years ago by mikeperry

Actual Points: 1
Points: 1
Resolution: fixed
Status: newclosed

Done. Will appear in 1.4.6, hopefully by the end of this month.

FYI: The torbutton design document should probably have a big warning on it that it is obsoleted by the Tor Browser design doc instead.. I guess I'll do that in the TBB update ticket.

comment:3 Changed 8 years ago by rat

Note that enabling Torbutton by default has the unintended consequence of bringing a user's restored session into the secure context, which is then deleted when the user closes the browser. I just lost over 180 tabs this way, and am somewhat annoyed, to put it mildly. I suggest you consider the implications before committing such changes in future. The problem could have been avoided by simply adding a warning about this possibility to the dialog box that pops up when the user start 1.4.6 for the first time.

Note: See TracTickets for help on using tickets.