Breakage in Firefox 15 nightlies due to E4X deprecation

Brian Carpenter reported UI breakage in the current (Firefox 15) nightly builds.

!http://i.imgur.com/8m0fZ.png

added component::https everywhere/eff-https everywhere owner::pde priority::immediate resolution::fixed severity::normal status::closed type::defect labels

I can reproduce this.  Error console shows me two errors that appear to be causing this:

Error: TypeError: can't wrap XML objects
Source File: chrome://https-everywhere/content/code/ApplicableList.js
Line: 195

Error: TypeError: can't wrap XML objects
Source File: chrome://https-everywhere/content/preferences.js
Line: 15

We also get these exceptions on lines 123, 125 and 127 of preferences.js

Googling this error message implies that it is normally caused by the use of "E4X".

It isn't at first obvious how that relates to places that are throwing these exceptions. However we use E4X in the functions ParseXmlRulesets and PraseOneRuleset, and the errors are being raised in places that refer to objects built from XML input in those functions.

So it seems that ParseXmlRulesets and ParseOneRuleset will need to be rewritten using some alternative non-E4X means of parsing XML rulesets.

Trac:
Cc: brian.carpenter@gmail.com to brian.carpenter@gmail.com, mikeperry
Summary: UI breakage in Firefox 15 nightlies to Breakage in Firefox 15 nightlies due to E4X deprecation

Trac:
Priority: critical to blocker

Another person reported seeing this, CC'ing them here. What we need is a patch that replaces all the E4X in ParseXmlRulesets and ParseOneRuleset with either cruder DOM inspection, or JXON.

Trac:
Cc: brian.carpenter@gmail.com, mikeperry to brian.carpenter@gmail.com, mikeperry, uu110@cfl.rr.com

Trac:
Username: JC_Yang
Cc: brian.carpenter@gmail.com, mikeperry, uu110@cfl.rr.com to brian.carpenter@gmail.com, mikeperry, uu110@cfl.rr.com, bandinfinite@gmail.com

Commit fc91c08f4a4260a123d3563fd0bd9765a7498d3d is meant to address this (via the "cruder DOM inspection" approach, getting rid of all the E4X syntax).

Trac:
Status: new to needs_review

That commit seems to work for me in FF 15.

That commit still does not fix the bug #6035 (moved).

Trac:
Status: needs_review to closed
Resolution: N/A to fixed

Set all tickets without a severity to "Normal"

Trac:
Severity: N/A to Normal

closed

mentioned in issue #6035 (moved)

mentioned in issue #6202 (closed)

mentioned in issue #6720 (closed)

moved to tpo/applications/https-everywhere-eff#5893 (closed)