Opened 7 years ago

Last modified 2 years ago

#5902 new defect

The whole "choose a doomed exit at random" business is busted

Reported by: nickm Owned by:
Priority: Medium Milestone: Tor: unspecified
Component: Core Tor/Tor Version:
Severity: Normal Keywords: tor-client paths circuit
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

From discussion on #3296:

If we ever hit the "doomed exit at random" message, *every* exit needs to have n_supported == -1. So if we seeing that one, not only is it hopeless to build a circuit to the chosen exit for your predicted port; it is also hopeless to try to build a circuit at all, I think.

Arma says: "We're launching a new circuit, repeatedly, when we really ought to be telling the stream to fail. This whole 'doomed exit' thing was supposed to improve our robustness during edge cases. But I think it just leads to sadness."

Child Tickets

Change History (10)

comment:1 Changed 7 years ago by Sebastian

rransom notes this is relevant for #5166

comment:2 Changed 7 years ago by nickm

Milestone: Tor: 0.2.3.x-finalTor: 0.2.4.x-final

Deferring any change here till 0.2.4.x. Could be backportable, maybe.

comment:3 Changed 7 years ago by nickm

Keywords: tor-client added

comment:4 Changed 7 years ago by nickm

Component: Tor ClientTor

comment:5 Changed 7 years ago by nickm

Milestone: Tor: 0.2.4.x-finalTor: 0.2.5.x-final

comment:6 Changed 6 years ago by nickm

Milestone: Tor: 0.2.5.x-finalTor: 0.2.???

comment:7 Changed 3 years ago by teor

Milestone: Tor: 0.2.???Tor: 0.3.???

Milestone renamed

comment:8 Changed 3 years ago by nickm

Keywords: tor-03-unspecified-201612 added
Milestone: Tor: 0.3.???Tor: unspecified

Finally admitting that 0.3.??? was a euphemism for Tor: unspecified all along.

comment:9 Changed 2 years ago by nickm

Keywords: tor-03-unspecified-201612 removed

Remove an old triaging keyword.

comment:10 Changed 2 years ago by nickm

Keywords: paths circuit added
Severity: Normal
Note: See TracTickets for help on using tickets.