Opened 8 years ago

Closed 8 years ago

Last modified 7 years ago

#5910 closed defect (fixed)

Tor does not ignore unknown managed proxy output

Reported by: asn Owned by:
Priority: Medium Milestone: Tor: 0.2.3.x-final
Component: Core Tor/Tor Version:
Severity: Keywords: pt tor-client
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Tor marks a managed proxy as broken when it receives unknown output from it.

This is bad for forward compatibility. The 180 spec also wants managed proxies to ignore unknown output:

  Tor MUST ignore lines with keywords that it doesn't recognize.

In src/or/transports.c:

  log_warn(LD_CONFIG, "Unknown line received by managed proxy. (%s)", line);

 err:
  mp->conf_state = PT_PROTO_BROKEN;
  log_warn(LD_CONFIG, "Managed proxy at '%s' failed the configuration protocol"
           " and will be destroyed.", mp->argv[0]);
}

Child Tickets

TicketStatusOwnerSummaryComponent
#5920closed"FAIL test_pt.c:104: assert(mp->conf_state == PT_PROTO_BROKEN)" introduced by #5910Core Tor/Tor

Change History (4)

comment:1 Changed 8 years ago by asn

Status: newneeds_review

Please see branch bug5910 in https://git.gitorious.org/mytor/mytor.git.

comment:2 Changed 8 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

looks ok; merging.

comment:3 Changed 7 years ago by nickm

Keywords: tor-client added

comment:4 Changed 7 years ago by nickm

Component: Tor ClientTor
Note: See TracTickets for help on using tickets.