Write patch to make socks handshakes succeed instantly

In #3875 (moved) Mike suggests we try out the usability of having the Tor in TBB just immediately succeed at all socks handshakes, and hang up if it gets an end cell rather than a connected cell.

We should whip up a Tor patch that does this behavior, so somebody can try it out.

(We may or may not want to merge it into mainline Tor branches. I guess it depends how complex the patch is and how successful the tests are.)

changed milestone to %Tor: unspecified

added 042-deferred-20190918 043-deferred application component::core tor/tor experiment intro milestone::Tor: unspecified needs-proposal performance performance? points::3 priority::medium reviewer::nickm severity::normal status::needs-revision tbb-wants? tor-client type::enhancement ux labels

This could be a socksport option, so that TBB could configure Tor with one "succeeds-immediately" socksport, and one regular socksport. That might be a good idea if (as I suspect) this breaks some but not all applications.

Trac:
Keywords: N/A deleted, tor-client added

Trac:
Component: Tor Client to Tor

Trac:
Points: N/A to 3
Keywords: tor-client deleted, tor-client intro performance application experiment added
Reviewer: N/A to N/A
Sponsor: N/A to N/A
Severity: N/A to Normal

I independently re-came up with the idea of using a socksport option, when thinking about the issues on #19910 (moved). I think it is a good idea.

I'm moving the milestone up for this one, since it is looking like Tor Browser is going to want to remove their hack, and have Tor pick up the hack burden.

Trac:
Milestone: Tor: unspecified to Tor: 0.3.4.x-final

Trac:
Cc: N/A to gk

Trac:
Keywords: N/A deleted, tbb-wants added

FWIW: There were some reasonable arguments to not try this at the tor level for Tor Browser. Instead we think we should fix the Firefox code to do the right thing for us. I'll leave this ticket open for the original idea.

Trac:
Milestone: Tor: 0.3.4.x-final to Tor: unspecified
Keywords: tbb-wants deleted, N/A added

this feature as a socksport option would be good choice

Trac:
tor-optimistic-data.patch

Optimistic Data patch for Tor.0.3.5.x

Trac:
Status: new to needs_review
Milestone: Tor: unspecified to Tor: 0.4.1.x-final

The added "Optimistic Data patch for Tor.0.3.5.x" is only a quick workaround test, needs review. you may will notice more often something like in logs:

Apr 08 21:12:04.000 [info] {EDGE} connection_edge_process_inbuf(): data from edge while in 'waiting for connect response' state. Sending it anyway. package_partial=0, buflen=181 Apr 08 21:12:04.000 [info] {EDGE} connection_edge_process_inbuf(): data from edge while in 'waiting for connect response' state. Sending it anyway. package_partial=1, buflen=181 Apr 08 21:12:04.000 [info] {EDGE} connection_edge_process_inbuf(): data from edge while in 'waiting for connect response' state. Sending it anyway. package_partial=0, buflen=517 Apr 08 21:12:04.000 [info] {EDGE} connection_edge_process_inbuf(): data from edge while in 'waiting for connect response' state. Sending it anyway. package_partial=1, buflen=19

Okay, please follow: https://trac.torproject.org/projects/tor/wiki/org/meetings/2018Rome/Notes/OptimisticData

Thanks for this patch!

But I think we need a proposal and spec for this feature, because we need to tell applications how to use it: https://trac.torproject.org/projects/tor/wiki/org/meetings/2018Rome/Notes/OptimisticData

Here's a bit more information about our proposals process: https://gitweb.torproject.org/torspec.git/tree/proposals/001-process.txt

Trac:
Status: needs_review to needs_information
Keywords: tor-client intro performance application experiment deleted, needs-proposal tor-client intro performance application experiment added
Milestone: Tor: 0.4.1.x-final to Tor: unspecified

We talked about this at All Hands. At the browser level we are not really concerned about the error handling. It's not bad as is without modification and we think we can make it better with relatively little effort.

So the path forward we like for this is to implement it in tor with an option on SocksPort that Tor Browser can set.

Trac:
Cc: gk to gk, tom