Opened 7 years ago

Closed 7 years ago

#5925 closed defect (fixed)

Going to an address with a space results in a Google query

Reported by: arma Owned by: mikeperry
Priority: High Milestone:
Component: Firefox Patch Issues Version:
Severity: Keywords: MikePerry201207, tbb-usability
Cc: Actual Points: 1
Parent ID: Points: 1
Reviewer: Sponsor:

Description (last modified by arma)

Type in "foo bar" on your address bar, and your Tor Browser will launch a google query.

It defaults to google and does not change to whatever search engine is selected in the search box.

Reported at https://blog.torproject.org/blog/new-tor-browser-bundles-17#comment-15623

Child Tickets

Change History (15)

comment:1 Changed 7 years ago by arma

Component: - Select a componentFirefox Patch Issues
Description: modified (diff)
Owner: set to mikeperry
Reporter: changed from cypherpunks to arma
Summary: Search using address bar uses googleGoing to an address with a space results in a Google query

Sorry for taking over your bug; I was just filing this one too. :)

comment:2 Changed 7 years ago by arma

Description: modified (diff)

comment:3 Changed 7 years ago by marshray

Sounds like it could be about:config browser.search.suggest.enabled.

comment:4 in reply to:  3 Changed 7 years ago by arma

Replying to marshray:

Sounds like it could be about:config browser.search.suggest.enabled.

That's disabled in my TBB already, isn't it?

comment:5 Changed 7 years ago by arma

When I change browser.search.defaultenginename to "Startpage", I get a popup "The URL is not valid and cannot be loaded." So at least I can break the google part. :)

comment:6 Changed 7 years ago by marshray

It's keyword.enabled then.

I also set browser.fixup.alternate.enabled to false if it's not already.

With neither set, typing "dogs" in the address bar searches Google. With keyword.enabled false, typing "dogs" in the address bar takes me to www.dogs.com which redirects to a commercial dog products vendor. With both false, typing "dogs" in the address bar gives me an error "Firefox can't find the server at dogs."

comment:7 Changed 7 years ago by arma

#6117 was filed as the same bug.

comment:8 Changed 7 years ago by cypherpunks

Do we want to disable it or redirect it to Startpage?

Changing only the keyword.URL with this:

https://startpage.com/do/search?q=

is working

comment:9 Changed 7 years ago by arma

Status: newneeds_review

comment:10 Changed 7 years ago by mikeperry

Keywords: MikePerry201206 added

Changing it to StartPage sounds good to me. The only reason I see not to provide this feature is the captcha.

comment:11 Changed 7 years ago by arma

...the captcha?

comment:12 Changed 7 years ago by mikeperry

The captcha from google. It's annoying. In my mind, that's the only reason to be concerned about this space -> query thing.

comment:13 Changed 7 years ago by mikeperry

Keywords: MikePerry201207 added; MikePerry201206 removed

Pushing this out because it's still not clear what will happen with startpage yet.

comment:14 Changed 7 years ago by mikeperry

Keywords: tbb-usability added
Priority: normalmajor

http://petsymposium.org/2012/papers/hotpets12-1-usability.pdf mentions the captcha redirect prompt as a significant usability issue. Switching our url bar search default to startpage will eliminate the captcha warning for all but direct Google users, and #6424 will be for that case.

comment:15 Changed 7 years ago by mikeperry

Actual Points: 1
Points: 1
Resolution: fixed
Status: needs_reviewclosed

This is fixed by setting keyword.URL to https://startpage.com/do/search?q=. However, I can't figure out why Marsh's suggested pref changes don't allow me to search with a single word without a space (ie dogs). For my TBB, regardless of what I set for those prefs, that always results in an attempted SOCKS connection instead of a startpage query. I created bug #6503 for that issue.

Note: See TracTickets for help on using tickets.