Opened 7 years ago

Last modified 2 years ago

#5978 new defect

Dead code, possible races, in NT service code

Reported by: nickm Owned by:
Priority: Low Milestone: Tor: unspecified
Component: Core Tor/Tor Version:
Severity: Normal Keywords: tor-relay, windows, nt-service windows-service
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

So, the nt_service_set_status function does nothing. (At least, not without a subsequent call to SetServiceStatus_fn, which there isn't).

Also, everything that sets or checks dwCurrentState in ntmain.c needs to be checked for race conditions, and to make sure that it isn't missing a call to QueryServiceStatus and/or SetServiceStatus.

(Reported pseudonymously on IRC. I probably have some details wrong here; more investigation will help)

Child Tickets

Change History (9)

comment:1 Changed 7 years ago by nickm

Milestone: Tor: 0.2.3.x-finalTor: 0.2.4.x-final

comment:2 Changed 7 years ago by nickm

Keywords: tor-relay added

comment:3 Changed 7 years ago by nickm

Component: Tor RelayTor

comment:4 Changed 7 years ago by nickm

Keywords: windows added
Milestone: Tor: 0.2.4.x-finalTor: 0.2.5.x-final

comment:5 Changed 6 years ago by nickm

Milestone: Tor: 0.2.5.x-finalTor: 0.2.???

comment:6 Changed 3 years ago by teor

Milestone: Tor: 0.2.???Tor: 0.3.???

Milestone renamed

comment:7 Changed 3 years ago by nickm

Keywords: tor-03-unspecified-201612 added
Milestone: Tor: 0.3.???Tor: unspecified

Finally admitting that 0.3.??? was a euphemism for Tor: unspecified all along.

comment:8 Changed 2 years ago by nickm

Keywords: tor-03-unspecified-201612 removed

Remove an old triaging keyword.

comment:9 Changed 2 years ago by nickm

Keywords: nt-service windows-service added
Priority: MediumLow
Severity: Normal
Note: See TracTickets for help on using tickets.