Opened 12 years ago

Closed 2 years ago

#608 closed defect (fixed)

Clients flip out when two routers use the same identity key

Reported by: nickm Owned by:
Priority: Low Milestone: Tor: unspecified
Component: Core Tor/Tor Version: 0.2.0.18-alpha
Severity: Normal Keywords: needs-proposal tor-relay
Cc: nickm, Sebastian Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description (last modified by nickm)

If two routers are set up to use the same identity key, the authorities will sometimes list both. This confuses
clients. Instead, authorities should only allow one server per key.

[Automatically added by flyspray2trac: Operating System: All]

Child Tickets

Change History (11)

comment:1 Changed 12 years ago by nickm

Probably, this needs a proposal.

comment:2 Changed 11 years ago by nickm

Indeed, this needs a proposal. I'm going to kick it out of "due in 0.2.1.x-final", since it needs some design
work, and since the fix should go in at the authorities rather than at the clients.

The problem is that, by our current voting rules, it's possible for two servers with the same ID to each get enough
votes from different authority sets for the consensus to include both. We should probably just add another rule
saying, "If the consensus algorithm results in having two servers with the same ID included, arbitrarily break
the tie in favor of ..." the one with the lower IP:Port? The one whose server descriptor fingerprint appears first?

comment:3 Changed 9 years ago by nickm

Milestone: post 0.2.1.xTor: 0.2.2.x-final

comment:4 Changed 9 years ago by nickm

Description: modified (diff)
Milestone: Tor: 0.2.2.x-final

Kicking this out of 0.2.2.x-final; nobody wrote the proposal. Again. :/

comment:5 Changed 9 years ago by nickm

Milestone: Tor: unspecified

comment:6 Changed 7 years ago by rransom

Is this bug still possible with the current directory protocol?

comment:7 Changed 7 years ago by nickm

I believe so?

comment:8 Changed 7 years ago by nickm

Keywords: needs-proposal added

comment:9 Changed 7 years ago by nickm

Keywords: tor-relay added

comment:10 Changed 7 years ago by nickm

Component: Tor RelayTor

comment:11 Changed 2 years ago by nickm

Cc: nickm,Sebastiannickm, Sebastian
Resolution: Nonefixed
Severity: Normal
Status: newclosed

This is no longer possible with how directory authorities work today.

Note: See TracTickets for help on using tickets.