Opened 7 years ago

Closed 6 years ago

#6085 closed defect (fixed)

[CHROME] Failure to display omnibar context menu if HTTPS times out

Reported by: pde Owned by: pde
Priority: Very High Milestone:
Component: HTTPS Everywhere/EFF-HTTPS Everywhere Version:
Severity: Keywords:
Cc: santiago.afonso@…, dtauerbach Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

In the Chrome port, if an HTTPS website times out, the user won't get a context menu to turn off the ruleset that HTTPSified things in the first place!

Child Tickets

Change History (9)

comment:1 Changed 7 years ago by pde

Cc: santiago.afonso@… added

comment:2 Changed 7 years ago by dtauerbach

Resolution: fixed
Status: newclosed

Fixed by commit 8d82be18dd803e22a05ce51ba7e8089762ee61a4 in gitosis@…:public/dan/https-everywhere.git. It still needs to be merged into the main repo's master branch.

comment:3 Changed 7 years ago by dtauerbach

Resolution: fixed
Status: closedreopened

(Re-opening until merge happens.)

comment:4 Changed 7 years ago by pde

Resolution: fixed
Status: reopenedclosed

Merged, and about to be released in chrome-2012.6.21

comment:5 Changed 7 years ago by pde

Resolution: fixed
Status: closedreopened

Dammit, I though we'd fixed this, but variants of this bug still seem to be lurking for me. Running 2012.6.21, visiting http://blip.tv is an example case.

comment:6 Changed 7 years ago by pde

Cc: dtauerbach added

comment:7 Changed 7 years ago by dtauerbach

I've added more event listeners to fire chrome.pageAction.show() in more possible situations. For the blip.tv case, onErrorOccurred appears to be the correct listener. However, although chrome.pageAction.show() is executing with the relevant tabId as an argument, curiously it does not seem to be working as the UI widget is still missing.

comment:8 Changed 7 years ago by pde

Is it possible for us to copy whatever AdBlock Plus for Chrome does? Its address bar icon seems to show up happily on these pages...

comment:9 Changed 6 years ago by semenko

Resolution: fixed
Status: reopenedclosed

We now display the icon independent of rulesets & across all tabs, via commit 876ed4f06ba

I can't repro this in the current stable version of Chrome w/ the extension from 2014.1.3. Marking as fixed.

Note: See TracTickets for help on using tickets.