Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#6092 closed defect (fixed)

Rebase TBB-Alpha to FF13.

Reported by: mikeperry Owned by: mikeperry
Priority: High Milestone:
Component: Firefox Patch Issues Version:
Severity: Keywords: MikePerry201206 tbb-rebase
Cc: g.koppen@…, rransom, erinn, Sebastian Actual Points: 4
Parent ID: Points: 2
Reviewer: Sponsor:

Child Tickets

Change History (8)

comment:1 Changed 7 years ago by mikeperry

I started this. Four of our patches did not apply cleanly: 0007, 0011, 0012, 0016 (using the current numbering in origin/maint-2.3).

comment:2 Changed 7 years ago by mikeperry

Oh, also spdy can store state and has a really long keepalive duration. We should clear that state upon New Identity, and ensure our patch to kill keepalive connections works for spdy, too.

Spdy is now on by default in FF13. Or at least it was supposed to be. Oddly, that was not mentioned in that developer doc.

comment:3 Changed 7 years ago by mikeperry

See #5282 for my super-brief spdy review and associated mutterings.

comment:4 Changed 7 years ago by gk

Cc: g.koppen@… added

comment:5 Changed 7 years ago by mikeperry

Cc: rransom added

This is turning out to be tricky. The usual automake build was broken in FF13. https://bugzilla.mozilla.org/show_bug.cgi?id=736961 seems to be the bug for it.

comment:6 Changed 7 years ago by mikeperry

Cc: erinn Sebastian added

Hooray, the patch in that bug fixes the compile. I've included it in my FF patches in mikeperry/ff13-patches. At Erinn's request, I moved them into an 'alpha' subdir. I have not updated TBB makefiles or anything of that nature, though.

comment:7 Changed 7 years ago by mikeperry

Actual Points: 4
Resolution: fixed
Status: newclosed

Ok, I double checked those bugs, and they don't seem to significantly affect content window fingerprinting. Modulo moving some patches around, I think my work is done here.

Note: I also disabled spdy in my branch, pending #6101 to adapt it to our needs.

comment:8 Changed 7 years ago by mikeperry

Keywords: tbb-rebase added
Note: See TracTickets for help on using tickets.