Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#6097 closed defect (fixed)

Build correctly with -DUNICODE -D_UNICODE again

Reported by: nickm Owned by:
Priority: Medium Milestone: Tor: 0.2.3.x-final
Component: Core Tor/Tor Version:
Severity: Keywords: windows unicode tor-client
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:


It looks like 0.2.3 doesn't build (for me at least) when -DUNICODE or "-DUNICODE -D_UNICODE" are passed in, and 0.2.2.x spews warnings. Better fix that.

OTOH, we could conceivably take this as a sign that nobody wants Tor built with -DUNICODE. Decisions, decisions.

Child Tickets

Change History (4)

comment:1 Changed 8 years ago by nickm

Status: newneeds_review

See branch "bug6097", which is built on "bug5909_023"

comment:2 Changed 8 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

Still looks okay to me. Merged it.

comment:3 Changed 8 years ago by nickm

Keywords: tor-client added

comment:4 Changed 8 years ago by nickm

Component: Tor ClientTor
Note: See TracTickets for help on using tickets.