Log warnings: Control[Port/ListenAddress], Socks[port/listenaddress], etc
These various warnings for the various subject options, as they and others might exist, are unnecessary and in bad form.
-
With no such config, client should default to 127.0.0.1 and the respective port, emitting just: Opening listener on 127.0.0.1:9050
-
If a user has need to change from the defaults, they've presumably found out about it from, and read the warnings in, the documentation. Logfiles are not the place for documentation.
-
And at over four times the standard 80 character line with, even without the timestamp and severity, it's really bad form for syslog style messages.
These are really unnecessary, please remove them. Or at least trim them down to fit within 80 chars: Non local configured, see warning in docs.
Examples:
[notice] You configured a non-loopback address for SocksPort. This allows everybody on your local network to use your machine as a proxy. Make sure this is what you wanted.
[warn] You have a ControlPort set to accept connections from a non-local address. This means that programs not running on your computer can reconfigure your Tor. That's pretty bad, since the controller protocol isn't encrypted! Maybe you should just listen on 127.0.0.1 and use a tool like stunnel or ssh to encrypt remote connections to your control port.