Opened 7 years ago

Closed 6 years ago

#6146 closed defect (duplicate)

Tor Browser resolution off by 50px sometimes?

Reported by: mikeperry Owned by: mikeperry
Priority: Very High Milestone:
Component: Firefox Patch Issues Version:
Severity: Keywords: tbb-fingerprinting
Cc: gk Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

We set the inner content window to a multiple of 200x100, but for some reason (some?) Windows users are getting multiples of 50 sometimes..

Child Tickets

Change History (24)

comment:1 Changed 7 years ago by mikeperry

Both Mac and Linux are properly sized to 200x100 multiples, afaict..

comment:2 in reply to:  1 Changed 7 years ago by Shondoit

Replying to mikeperry:

Both Mac and Linux are properly sized to 200x100 multiples, afaict..

My Ubuntu 12.04 x86_64 started with 1000x650.

comment:3 Changed 7 years ago by mikeperry

Summary: Windows Tor Browser resolution off by 50px?Tor Browser resolution off by 50px sometimes?

Bleh. Are you using Unity?

comment:4 in reply to:  3 Changed 7 years ago by Shondoit

I was at the time, but I just tried with Gnome 3 as well and observed the same.

comment:5 Changed 7 years ago by cypherpunks

Does nobody else experience the same issue?

comment:6 Changed 7 years ago by mikeperry

Might this be due to the find bar or other additional/temporary browser toolbars?

comment:7 Changed 7 years ago by mikeperry

I just noticed that my Mac is subject to a variant of this bug. It seems like the resize code might be being overridden by MacOS refusing to allow a window to be sized such that it intrudes on the dock...

comment:8 Changed 7 years ago by mikeperry

There's another potential case involving scrollbars. Since we resize the window before it's rendered, if the content causes horizontal or vertical scrollbars to appear afterwords, the resolution numbers can be off by the size of the scrollbars...

comment:9 Changed 7 years ago by mikeperry

The best way to solve this might be #7256.

comment:10 Changed 7 years ago by cypherpunks

I was the original reporter of this problem. The current situation is the worst ever.

On Windows 7, with bookmars toolbar open, this is my browser screen size now:

961 x 467

This is unbelievable.

comment:11 Changed 7 years ago by cypherpunks

Priority: majorcritical

comment:12 Changed 7 years ago by mikeperry

Priority: criticalmajor

If you open any toolbars after creating the window, your resolution will be the new content window size. We could try to resize the window again on these events, but I'm not sure it is worth it, since the intermediate size might still be detected by content. Certainly seems like a separate bug to handle that case anyway.

For this bug, I'm more interested in understanding the cases where a brand new windows are weird sizes.

Also, please don't set priorities on bugs to high levels just because they personally annoy you. I do not believe that allowing a website to temporarily see that you resized your browser window is a "critical" fingerprinting vulnerability, especially since the website is not given information as to if this was a toolbar being opened vs any other type of window resize.

comment:13 Changed 7 years ago by cypherpunks

Sorry for not providing enough info. But I'm sure this is not a personal problem. Here are the tests:

OS: Windows 7 + 1366x768

I used panopticlick-browserspy and ip-check.info to test my screen sizes. (ip-check shows 33 less pixels than the other two)

I did these step by step:

On fresh Tor Browser install:
959x596 (on ip-check.info 959x563)

After restarting Tor Browser or clicking on New Identity:
961x600 (ip-check 961x567)

Now enabling the Bookmarks Toolbar:
961x574 (ip-check 961x541)

After restart or new identity (bookmarks toolbar still enabled):
961x500 (ip-check 961x467)

Please make your own tests with the most common operating systems.

Since Torbutton 1.4.6 I'm seeing very weird screen sizes (especially on Windows 7, tested on different computers)

comment:14 Changed 7 years ago by cypherpunks

I think the best thing to do is to collect and analyze the TBB users' fingerprints:

#6119

comment:15 Changed 7 years ago by cypherpunks

Updating my test with the latest tor browser 2.3.25-4, with the same operating system.

On fresh install: 998x567

If I press New Identity: 1000x573
If I restart the browser: 1000x571

This time enabling bookmarks toolbar didn't change the results (getting 1000x573 and 1000x571)

comment:16 Changed 7 years ago by cypherpunks

Priority: majorcritical

Is this not a serious problem? Not because the sizes are ok in linux? I guess most people are using TBB on Windows and nobody cares

comment:17 Changed 7 years ago by arma

"Nobody cares" and "nobody has the fix" are two different notions.

Best way to get it fixed is to figure out what the issue is and write a patch.

Another way is to be polite and helpful -- and patient.

comment:18 Changed 7 years ago by mikeperry

https://gitweb.torproject.org/torbutton.git/blob/master:/src/chrome/content/torbutton.js#l2004 is the source in question if you'd like to work on it yourself.

Otherwise, I'll try to give a look at this after I get a Windows build machine working (which is proving to be exceedingly difficult). Given other bugs with FF17, most likely nothing will happen for another week or two, at least. Probably longer.

Repeatedly freaking out on trac is only going to slow everything down even more. Every trac post I need to write trying to calm people down is time where nothing is getting fixed, and every bug from TBB17 seems to have at least one crackpot unhelpfully screaming on it and fighting with us over ticket priority changes lately...

comment:19 Changed 7 years ago by cypherpunks

Testing the TBB in Whonix,

1000x572

comment:20 Changed 7 years ago by mikeperry

Keywords: MikePerry201304 added

comment:21 Changed 7 years ago by mikeperry

See also #8478.

comment:22 Changed 6 years ago by mikeperry

Cc: gk added

comment:23 Changed 6 years ago by mikeperry

Keywords: MikePerry201305 added; MikePerry201304 removed

comment:24 Changed 6 years ago by mikeperry

Keywords: MikePerry201305 removed
Resolution: duplicate
Status: newclosed

I am just going to call this a dup of #8478. I think its fix will solve this too.

Note: See TracTickets for help on using tickets.