Opened 5 years ago

Closed 4 years ago

#6147 closed defect (fixed)

Can't edit torrc from within Vidalias' interface

Reported by: bastik Owned by: chiiph
Priority: Medium Milestone:
Component: Archived/Vidalia Version: Vidalia: 0.2.19
Severity: Keywords: easy
Cc: karulis@…, bastik.public@…, onizuka.xxxx@…, erinn, meitarm+torproject.H6tsywSw7GkG1Mem@… Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

A user reports for: Tor Browser Bundle (2.2.37-1)

Any attempt at editing and saving the torrc file via Vidalias' interface:

Settings-->Advanced-->Edit current torrc-->OK

fails with the popup message:

Error at line 1: ""

This happens even without editing the file.

I can reproduce this error on Windows 7 (64bit). You can edit the file manually with your favorite notepad. Tor accepts the changes, so I assume that the bug is within Vidalia.

Child Tickets

Attachments (1)

vidalia-torrc.patch (1.2 KB) - added by karulis 5 years ago.
patch

Download all attachments as: .zip

Change History (16)

comment:1 follow-up: Changed 5 years ago by cypherpunks

Removing the first two commented lines will allow you to save the file.

This is also present for tor-browser-gnu-linux-i686-2.2.37-1-dev-en-US

comment:2 in reply to: ↑ 1 Changed 5 years ago by cypherpunks

Replying to cypherpunks:

Removing the first two commented lines will allow you to save the file.

This is also present for tor-browser-gnu-linux-i686-2.2.37-1-dev-en-US

Any commented lines will result in the Error message

Changed 5 years ago by karulis

patch

comment:3 Changed 5 years ago by karulis

  • Cc karulis@… added
  • Status changed from new to needs_review

Now when parsing we skip lines that are commentaries or empty.

comment:4 Changed 5 years ago by bastik

  • Cc bastik.public@… added

This is obviously present in Vidalia 0.2.20, which is included in the browser bundles, bridge and relay bundles.

My torrc files contained comments all the time and Vidalia never cared, I wonder what has changed so it "cares" about them.

(I wanted to add myself as CC, too)

comment:5 Changed 5 years ago by mo

Any update on this? Patch looks okay to me.

comment:6 Changed 4 years ago by onizuka

  • Cc onizuka.xxxx@… added
  • Keywords easy added

The patch looks also good to me and resolves the issue which is still present in the master branch (0.2.21).

comment:7 Changed 4 years ago by erinn

  • Cc erinn added

comment:8 Changed 4 years ago by meitar

  • Cc meitarm+torproject.H6tsywSw7GkG1Mem@… added

comment:9 Changed 4 years ago by chiiph

  • Resolution set to fixed
  • Status changed from needs_review to closed

This has been merged to master. Sorry for the delay

comment:10 Changed 4 years ago by runa

  • Resolution fixed deleted
  • Status changed from closed to reopened

This is still an issue (TBB 2.3.25-5-osx-x86_64-en_US).

comment:11 Changed 4 years ago by runa

chiiph says this has been fixed in the code, but there is no release of Vidalia with the fix in it. He says he's not sure when there will be a new release.

comment:12 follow-up: Changed 4 years ago by anic92

I am on mac 10.6.8, and having the same error with line 1 problem while using the latest version of the tor browser bundle. How I can I fix this? Thanks

comment:13 in reply to: ↑ 12 Changed 4 years ago by lance

Replying to anic92:

I am on mac 10.6.8, and having the same error with line 1 problem while using the latest version of the tor browser bundle. How I can I fix this? Thanks

Take out the commented lines, I believe its the top two. This happens on some versions of vidalia. Let me know if this fixes it for you.

comment:14 Changed 4 years ago by lance

  • Status changed from reopened to needs_information

comment:15 Changed 4 years ago by mo

  • Resolution set to fixed
  • Status changed from needs_information to closed

Why did you change the state to "needs_information"? "needs_information" reflects that the bug cannot be assessed without additional information about the bug (from the reporter[s]). This bug has been fixed in the code base, but it does not look like there will be a new release of Vidalia in the near future that contains the fix. As such, I'd say the bug is "fixed", although the fix is not readily available. Which is very sad.

You can either remove the commented lines, or select only the lines with changes and tick "apply only selected lines" (or whatever it's called in Vidalia).

The soon-to-be stable Tor Browser Bundle v3 will not have Vidalia any more.

Note: See TracTickets for help on using tickets.