Opened 6 years ago

Closed 5 years ago

#6164 closed defect (fixed)

Possible assertion failure triggered by control port

Reported by: rransom Owned by:
Priority: High Milestone: Tor: 0.2.4.x-final
Component: Core Tor/Tor Version:
Severity: Keywords: tor-client
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:


In routerstatus_format_entry (in src/or/dirserv.c):

      /* This assert can fire for the control port, because
       * it can request NS documents before all descriptors
       * have been fetched. */

This needs to be investigated during 0.2.4.x-alpha, and the fix may need to be backported.

Child Tickets

Change History (5)

comment:1 Changed 5 years ago by nickm

Keywords: tor-client added

comment:2 Changed 5 years ago by nickm

Component: Tor ClientTor

comment:3 Changed 5 years ago by nickm

Status: newneeds_review

I believe that this is just a bad comment; the "can" should be "could". Note that the entire block is wrapped inside "if (format != NS_CONTROL_PORT)".

Proposed comment fix in branch "bug6164" in my public repo for review.

comment:4 Changed 5 years ago by andrea

Looks okay for merge

comment:5 Changed 5 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

Merged; thanks!

Note: See TracTickets for help on using tickets.