Opened 5 years ago

Closed 5 years ago

#6172 closed defect (fixed)

GETCONF responses must be quoted

Reported by: neena Owned by:
Priority: Medium Milestone: Tor: 0.2.4.x-final
Component: Core Tor/Tor Version: Tor: unspecified
Severity: Keywords: control tor-client tor-spec
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:


The control spec says

 264   Value may be a raw value or a quoted string.  Tor will try to use
 265   unquoted values except when the value could be misinterpreted through
 266   not being quoted.


GETCONF returns values which seperated by spaces without quoting them (this would be something that could be misinterpreted). Tor should respond with quoted values.


getconf log
250 Log=notice stdout

should be

getconf log
250 Log="notice stdout"

Child Tickets

Change History (8)

comment:1 Changed 5 years ago by nickm

Keywords: control spec-conformance added
Milestone: Tor: 0.2.4.x-final

Worth correcting, though we will need to double-check that we won't break any controllers by doing this.

comment:2 Changed 5 years ago by nickm

Keywords: tor-client added

comment:3 Changed 5 years ago by nickm

Component: Tor ClientTor

comment:4 Changed 5 years ago by nickm

Actually, how could that be misinterpreted though lack of quotes? Each option gets its own line, so there's no way to think that your'e dealing with a separate option there.

comment:5 Changed 5 years ago by atagar

Good point. Sounds like the spec should simply not mention that the value may be quoted? Or could there be a multi-line value that needs quotes?

comment:6 Changed 5 years ago by nickm

Keywords: spec added; spec-conformance removed

I don't think we support multi-line configuration options, so just removing the suggestion that it might be quoted here is probably good enough.

comment:7 Changed 5 years ago by nickm

Keywords: tor-spec added; spec removed

Bulk-replacing "spec" and "torspec" keywords with "tor-spec".

comment:8 Changed 5 years ago by nickm

Resolution: fixed
Status: newclosed

Fixed in 459b3c93b2041bca718b6ce7fdaf5cb5864f5cc3

Note: See TracTickets for help on using tickets.