Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#6202 closed defect (fixed)

Rewrite E4X cooke storing+parsing code

Reported by: mikeperry Owned by: mikeperry
Priority: Very High Milestone:
Component: TorBrowserButton Version:
Severity: Keywords: tbb-rebase-regression, MikePerry201303
Cc: Actual Points: 4
Parent ID: Points:
Reviewer: Sponsor:

Description

Firefox 15 deprecates support for E4X, which we use in Torbutton to read and write protected cookies and maybe for some other stuff too. We need to rewrite that code to use xpath, JXON, or DOM manipulations.

HTTPS-Everywhere chose DOM manipulations. See #5893.

Child Tickets

Attachments (1)

torbutton-1.5.1pre7.xpi (818.6 KB) - added by mikeperry 7 years ago.
Replace E4X with JSON for cookie protections.

Download all attachments as: .zip

Change History (9)

comment:1 Changed 7 years ago by mikeperry

Keywords: MikePerry201208 added; MikePerry201207 removed

comment:2 Changed 7 years ago by mikeperry

Keywords: MikePerry201210 added; MikePerry201208 removed
Priority: majorcritical

https://developer.mozilla.org/en-US/docs/E4X says we've got until Firefox 17! Woo hoo. That's like a million months from now. However, that is also the next ESR release, so if we don't get this done before then, we're going to be extra sad.

comment:3 Changed 7 years ago by mikeperry

Keywords: tbb-rebase added

comment:4 Changed 7 years ago by mikeperry

Keywords: MikePerry201210 removed
Parent ID: #7248

comment:5 Changed 7 years ago by mikeperry

Parent ID: #7248

Changed 7 years ago by mikeperry

Attachment: torbutton-1.5.1pre7.xpi added

Replace E4X with JSON for cookie protections.

comment:6 Changed 7 years ago by mikeperry

Keywords: tbb-rebase-regression added; tbb-rebase removed

That test XPI is from torbutton.git origin/mater, commit 4f585aa6cf7a5c9097fa4474fd150a5d1c291048.

comment:7 Changed 7 years ago by mikeperry

Actual Points: 2
Keywords: MikePerry201303 added
Resolution: fixed
Status: newclosed

This should be in TBB-2.3.25-5.

comment:8 Changed 7 years ago by mikeperry

Actual Points: 24
Note: See TracTickets for help on using tickets.