Opened 5 years ago

Closed 4 years ago

#6206 closed defect (user disappeared)

logging error of integ tests on Windows

Reported by: reganeet Owned by: reganeet
Priority: Medium Milestone:
Component: Core Tor/Stem Version:
Severity: Keywords: testing
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

When I ran the integ tests on Windows, Pythons threw a whole lot of error of logging:
http://pastebin.com/v8Hicvs2

This problem might be related to time.strftime() on Windows:
http://stackoverflow.com/a/9267262/994146
stem.util.log uses "datefmt = '%D %H:%M:%S'", where "%D" is not a documented directive:
http://docs.python.org/library/time.html#time.strftime
However, changing "%D" to "%m/%d/%y" does not solve the problem.

Child Tickets

Change History (7)

comment:1 Changed 5 years ago by atagar

  • Status changed from new to needs_information

This problem might be related to time.strftime() on Windows

Yup, turns out that time.strftime is partly platform specific...
http://stackoverflow.com/questions/10807164/python-time-formatting-different-in-windows

Issue is probably our two "datefmt = '%D %H:%M:%S'" entries...
https://gitweb.torproject.org/stem.git/blob/HEAD:/stem/util/log.py#l164

The strftime pydocs has %H, %M, and %S but not %D so that's probably Linux specific. I'm using it to provide the date, for example...

07/07/12 20:40:27 [INFO] We made a PROTOCOLINFO version 1 query...

Pushed a change that should fix this...
https://gitweb.torproject.org/stem.git/commitdiff/a325a40

Mind checking if it works now?

comment:2 Changed 5 years ago by reganeet

Unfortunately the problem remains...actually I've tried this solution before; it did not work :(

Beck

comment:3 Changed 5 years ago by atagar

  • Status changed from needs_information to new

Gah, I haven't a clue then. If you remove the date entirely does it work? Are their any particular logging functions that you can disable to make this issue go away?

comment:4 Changed 5 years ago by reganeet

If you remove the date entirely does it work?

Uh-oh, no good. 

Are their any particular logging functions that you can disable to make this issue go away?

Do you mean the logging functions in Python or stem? Should I just try to comment out the functions one by one and see what happens?

comment:5 Changed 5 years ago by atagar

Do you mean the logging functions in Python or stem? Should I just try to comment out the functions one by one and see what happens?

Yup, or whatever you think could narrow down the haystack. If need to isolate this problem first before we can address it. And, even if we can't fix it, if you narrow this down to a particular call by stem then we can mitigate it by adding an is_windows() check.

comment:6 Changed 4 years ago by atagar

  • Keywords testing added

comment:7 Changed 4 years ago by atagar

  • Resolution set to user disappeared
  • Status changed from new to closed

Unfortunately this ticket isn't going anywhere, and won't without someone to debug this on Windows. Resolving - feel free to reopen if you have time at some point to troubleshoot further.

Note: See TracTickets for help on using tickets.