Opened 7 years ago

Closed 7 years ago

#6212 closed defect (fixed)

Enable/disable toggling is buggy in Firefox 15

Reported by: cypherpunks Owned by: pde
Priority: High Milestone:
Component: HTTPS Everywhere/EFF-HTTPS Everywhere Version:
Severity: Keywords:
Cc: me@… Actual Points:
Parent ID: #4804 Points:
Reviewer: Sponsor:

Description

via the toolbar icon or via the menu (tools--https everywhere-->disable https everywhere)
a) clicking on disable https everywhere causes the current tab to refresh, which it's always done
b) click on toolbar icon and note that the rulesets are still listed as enabled
c) load another page that triggers rulesets. note that the rule sets are no longer listed as active and "enable https everywhere" appears.

I can still disable the addon itself from the addon manager.

3.0b4, ff aurora, mac 10.6.8

Child Tickets

Change History (9)

comment:1 Changed 7 years ago by jzhu

Cc: me@… added

comment:2 Changed 7 years ago by pde

Let me check whether I understand this report completely: you have HTTPS Everywhere disabled internally (ie, from within the toolbar button), but it's still showing active rulesets? Is it also rewriting things according to those rulesets?

What version of aurora are you running?

comment:3 Changed 7 years ago by pde

Status: newaccepted

Okay, I can reproduce this running FF 15a2. I see the following console error:

{{{Timestamp: 06/22/2012 03:08:49 PM
Error: TypeError: can't access dead object
Source File: chrome://https-everywhere/content/code/ApplicableList.js
Line: 72}}}

comment:4 Changed 7 years ago by pde

Summary: weird behavior when disabling rulesEnable/disable toggling is buggy in Firefox 15

The bug is happening on line 72. Most likely an FF internals change, but it could also be a side effect of these changes

comment:5 Changed 7 years ago by pde

Priority: normalmajor

comment:6 Changed 7 years ago by pde

<mccr8> pde: you can't access windows after they are closed now, I think that's what the error message is.
<mccr8> pde: http://blog.kylehuey.com/post/21892343371/fixing-the-memory-leak may or may not be useful.

comment:7 Changed 7 years ago by pde

Parent ID: #4804

The underlying reference maintenance /may/ be a contributing factor to #4804, though I'm not sure how much.

comment:8 Changed 7 years ago by pde

Fixed in this commit. Will be released in 3.0development.5.

comment:9 Changed 7 years ago by pde

Resolution: fixed
Status: acceptedclosed

Shipped.

Note: See TracTickets for help on using tickets.