Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#6218 closed defect (fixed)

wrong max port range in parse_port_range()

Reported by: asn Owned by:
Priority: Medium Milestone: Tor: 0.2.3.x-final
Component: Core Tor/Tor Version:
Severity: Keywords: tor-relay
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

https://gitweb.torproject.org/tor.git/blob/HEAD:/src/common/address.c#l1529 :

      port_max = (int)tor_parse_long(port, 10, 1, 65536, &ok, &endptr);

The good thing is that if 65536 is given as port_max in the above code, it's still caught by:

  if (port_max > 65535)
    port_max = 65535;

Child Tickets

Change History (5)

comment:1 Changed 7 years ago by asn

Status: newneeds_review

Please see branch bug6218 in https://git.gitorious.org/mytor/mytor.git.

comment:2 Changed 7 years ago by nickm

Instead see branch "bug6218_cherrypick" in my public repo. I'd merge it, but I think arma is putting out an rc as I type this.

comment:3 Changed 7 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

cherrypicked again and merged. thanks!

comment:4 Changed 7 years ago by nickm

Keywords: tor-relay added

comment:5 Changed 7 years ago by nickm

Component: Tor RelayTor
Note: See TracTickets for help on using tickets.