Opened 7 years ago

Closed 2 years ago

#6245 closed defect (wontfix)

Formatting 'getinfo address-mappings/all', and others

Reported by: grarpamp Owned by:
Priority: Medium Milestone: Tor: unspecified
Component: Core Tor/Tor Version: Tor: 0.2.3.17-beta
Severity: Normal Keywords: tor-client tor-control
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Please adjust the output of 'getinfo address-mappings/all' such
that when there is only one entry, it is presented on a new line
separate from the leading 250 header. ie: not this one liner...

250-address-mappings/all=*.example.com <fingerprint>.exit NEVER

Child Tickets

Change History (8)

comment:1 Changed 7 years ago by grarpamp

Summary: Formatting 'getinfo address-mappings/all'Formatting 'getinfo address-mappings/all', and others

Oops, also applies to 'getinfo stream-status' and probably a bunch of other stuff :)

comment:2 Changed 7 years ago by nickm

Milestone: Tor: 0.2.3.x-finalTor: unspecified

For 0.2.3.x, that's a "no way" -- it's already in beta, and I want an rc out asap.

For future releases, my biggest worry here would be that changing the current behavior would break vidalia, or one of the other controllers or controller libraries. Testing would be needed at least.

comment:3 Changed 7 years ago by grarpamp

Also, I'm not sure of the necessity of the trailing dot '.' in the multiline output format when a '250 OK' follows both single and multi line anyways. The dot could be interpreted as data, requires extra treatment, and this probably isn't smtp :)

comment:4 in reply to:  3 Changed 7 years ago by rransom

Replying to grarpamp:

Also, I'm not sure of the necessity of the trailing dot '.' in the multiline output format when a '250 OK' follows both single and multi line anyways. The dot could be interpreted as data, requires extra treatment, and this probably isn't smtp :)

The control-port protocol has a spec, and it is in fact modeled on SMTP.

comment:5 Changed 7 years ago by grarpamp

Docs, schmox :)
Ok it's around line 450 in said doc, will try to observe the magic behind it later.

verbage: In play, there's an entry per line, yet 'whether value fits or split over lines' implies line wrapping/mushing of said entries. I'd probably say 'whether single or multi entries'. The value is just the whole set/reply.

Single and multi seems more cases for dummies like me to parse around.

comment:6 Changed 7 years ago by nickm

Keywords: tor-client added

comment:7 Changed 7 years ago by nickm

Component: Tor ClientTor

comment:8 Changed 2 years ago by nickm

Keywords: tor-control added
Resolution: wontfix
Severity: Normal
Status: newclosed

Calling this wontfix -- any application that doesn't handle this right is setting itself up for disaster if we do some other (but still spec-supported!) behavior in the future.

I hope we learned a lesson about changing specified things "Because The Spec Says We Can" that one time when we reordered some control-port options and broke all the controllers.

That's not to say we'll never break a controller again, but if we do so, we should have a proportionally good reason.

Note: See TracTickets for help on using tickets.