Opened 7 years ago

Closed 7 years ago

#6250 closed task (implemented)

Stem's convenience method for saving configuration using SAVECONF

Reported by: neena Owned by: neena
Priority: Medium Milestone:
Component: Core Tor/Stem Version:
Severity: Keywords:
Cc: neena, atagar Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

I'm implementing the convenience method for saving Tor's current configuration using SAVECONF.

My implementation is here (this commit). I've based it off my setconf branch because it's using the SingleLineResponse I implemented in it, so this will have to merged after that (which is based on the getconf parsing, because the tests need it). I wish had done this seperately, but, *shrug*.

I also fixed a few things in the documentation which reappeared after a bad rebase to master. such as...

-  :var str code: The error code returned by Tor (if applicable)
-  :var str message: The error message returned by Tor (if applicable) or a human
+  :var str code: The error code returned by Tor
+  :var str message: The error message returned by Tor or a human

Child Tickets

Change History (5)

comment:1 Changed 7 years ago by neena

Owner: changed from atagar to neena
Status: newassigned

comment:2 Changed 7 years ago by neena

Status: assignedneeds_review

comment:3 Changed 7 years ago by neena

Status: needs_reviewneeds_revision

comment:4 Changed 7 years ago by neena

Status: needs_revisionneeds_review

I've rebased to master, so the link to the commit in the ticket won't work, but it's the same branch.

comment:5 Changed 7 years ago by atagar

Resolution: implemented
Status: needs_reviewclosed

Great change! Pushed - I couldn't think of any bits to twiddle this time. :P

I have added an InsatisfiableRequest class which will

Heh, threw me off for a second since 'insatisfiable' isn't a word. It's right in the change, though.

I've also added a super class for non-socket non-protocol errors called
OperationFailed. Any error that was raised by an error response returned
by Tor (i.e., one with an error code & a message) should subclass this.

Good idea.

Note: See TracTickets for help on using tickets.