Opened 7 years ago
Closed 7 years ago
#6302 closed enhancement (fixed)
Use SOCK_ERRNO consistently
Reported by: | nickm | Owned by: | |
---|---|---|---|
Priority: | Low | Milestone: | Tor: 0.2.4.x-final |
Component: | Core Tor/Tor | Version: | |
Severity: | Keywords: | tor-client | |
Cc: | Actual Points: | ||
Parent ID: | Points: | ||
Reviewer: | Sponsor: |
Description
Everywhere that we currently say
#ifdef _WIN32 frobnicate(WSAENOWOMBATS); #else frobnicate(ENOWOMBATS); #endif
we ought instead to just say:
frobincate(SOCK_ERRNO(ENOWOMBATS));
in order to help get internal #ifdefs out of our functions.
Child Tickets
Change History (5)
comment:1 Changed 7 years ago by
Keywords: | tor-client added |
---|
comment:2 Changed 7 years ago by
Component: | Tor Client → Tor |
---|
comment:3 Changed 7 years ago by
Status: | new → needs_review |
---|
Note: See
TracTickets for help on using
tickets.
Please review bug6302; I tested by compiling on osx and cross-compiling with mingw32.