Opened 7 years ago

Closed 7 years ago

#6302 closed enhancement (fixed)

Use SOCK_ERRNO consistently

Reported by: nickm Owned by:
Priority: Low Milestone: Tor: 0.2.4.x-final
Component: Core Tor/Tor Version:
Severity: Keywords: tor-client
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Everywhere that we currently say

#ifdef _WIN32
  frobnicate(WSAENOWOMBATS);
#else
  frobnicate(ENOWOMBATS);
#endif

we ought instead to just say:

  frobincate(SOCK_ERRNO(ENOWOMBATS));

in order to help get internal #ifdefs out of our functions.

Child Tickets

Change History (5)

comment:1 Changed 7 years ago by nickm

Keywords: tor-client added

comment:2 Changed 7 years ago by nickm

Component: Tor ClientTor

comment:3 Changed 7 years ago by nickm

Status: newneeds_review

Please review bug6302; I tested by compiling on osx and cross-compiling with mingw32.

comment:4 Changed 7 years ago by andrea

This looks just fine.

comment:5 Changed 7 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

Thanks; merged!

Note: See TracTickets for help on using tickets.