Opened 7 years ago

Closed 6 years ago

#6330 closed defect (fixed)

Catch output and exit status of registration helpers

Reported by: dcf Owned by: dcf
Priority: Low Milestone:
Component: Archived/Flashproxy Version:
Severity: Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Registration helpers (currently only flashproxy-reg-http.py can print to stdout or stderr and the output goes to the stream; rather flashproxy-client.py should take that output and log it in the normal fashion.

Similarly, we should check for a nonzero exit status and log a failure to register. I think this can be done as easily as installing a SIGCHLD handler, but SIGCHLD is not supported on Windows according to http://docs.python.org/library/signal#signal.signal.

Child Tickets

Change History (1)

comment:1 Changed 6 years ago by dcf

Resolution: fixed
Status: newclosed

How I did this in 89e54229 is with blocking subprocesses in a dedicated registration thread. When #5426 is done, I plan to change this into just one blocking call in the foreground with no thread.

Note: See TracTickets for help on using tickets.