Opened 5 years ago

Closed 5 years ago

#6356 closed task (implemented)

LOADCONF wrapper method for Stem

Reported by: neena Owned by: neena
Priority: Medium Milestone:
Component: Core Tor/Stem Version:
Severity: Keywords:
Cc: atagar Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Stem must implement a wrapper method around LOADCONF control messages.

My branch implementing this is here. (It has has a few minor aesthetic changes to the code).

Child Tickets

Change History (3)

comment:1 Changed 5 years ago by neena

  • Owner changed from atagar to neena
  • Status changed from new to assigned

comment:2 Changed 5 years ago by neena

  • Status changed from assigned to needs_review

comment:3 Changed 5 years ago by atagar

  • Resolution set to implemented
  • Status changed from needs_review to closed

Changes pushed, thanks!

Minor thing, but when you have a long list of things like...

+all = [
+ "descriptor",
+ "response",
+ "util",
+ "connection",
+ "control",
+ "prereq",
+ "process",
+ "socket",
+ "version"
+]

... please include a comma on the last element. This makes reordering the elements a little less error prone.

[LOADCONF was added in Tor 0.2.1.1-alpha.]

When a feature has a version requirement please add it to 'stem.version.Requirement' and add a version requirement for the test.

Here's the revisions that I made to your changes...
https://gitweb.torproject.org/stem.git/commitdiff/ab553f54e70ea21d8bd117cf912e1b208417e5d5

Cheers! -Damian

Note: See TracTickets for help on using tickets.