Opened 5 years ago

Closed 5 years ago

#6357 closed task (implemented)

Stem's exception classes should be moved to the module's top level

Reported by: neena Owned by: neena
Priority: Medium Milestone:
Component: Core Tor/Stem Version:
Severity: Keywords:
Cc: atagar Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Stem's controller library part currently defines & raises some exceptions all of which are defined in the submodule stem.socket.

While it made sense to have them there while the only exceptions that were raised were SocketClosed & SocketError, now that it includes a more non-socket related exceptions than socket related ones I think it makes sense to move them to the module's top level. (Things like InvalidRequest & InvalidArguments).

If we're doing this, I can make the changes along with my controller class modifications.

(stem.socket.InvalidRequest would become stem.InvalidRequest and so on.)

Child Tickets

Change History (4)

comment:1 Changed 5 years ago by atagar

Oops, guess that I should reply here too. Yup, as mentioned on irc I like the idea of moving the exceptions into the init file.

(Things like InvalidRequest & InvalidArguments).

Lets make this an all-or-nothing move. Otherwise it's a bit more confusing where users should look for exception classes and the pydoc with the exception hierarchy.

comment:2 Changed 5 years ago by atagar

Status: newneeds_information

Hi Ravi. This has been open for four months. Is this still of interest?

comment:3 in reply to:  2 Changed 5 years ago by neena

Status: needs_informationneeds_review

Replying to atagar:

Hi Ravi. This has been open for four months. Is this still of interest?

Yep. Please review http://repo.or.cz/w/stem/neena.git/shortlog/refs/heads/toplvl-exceptions

comment:4 Changed 5 years ago by atagar

Resolution: implemented
Status: needs_reviewclosed
Note: See TracTickets for help on using tickets.