Allow config option TestingTorNetwork if AlternateDirAuthority is set

We don't allow TestingTorNetwork to be set if DirServer is not set. We should allow it if AlternateDirAuthority is set.

changed milestone to %Tor: unspecified

added component::core tor/tor milestone::Tor: unspecified priority::medium resolution::fixed status::closed tor-relay type::defect labels

Branch bug6377 in my public repo should fix this.

Trac:
Status: new to needs_review

This probably wants to be on maint-0.2.3 if it's needed for testing?

It needs a changes file.

I'm not too sure that I understand the rationale, and that it's truly safe: Is it really a good idea to let testing networks talk to real Bridge authorities?

Trac:
Milestone: N/A to Tor: unspecified

Replying to nickm:

This probably wants to be on maint-0.2.3 if it's needed for testing?

That could be helpful, yes.

It needs a changes file.

Added, see branch bug6377_rebased2 in my repo.

I'm not too sure that I understand the rationale, and that it's truly safe: Is it really a good idea to let testing networks talk to real Bridge authorities?

You are right, it's not. Changed it to require both AlternateDirAuthority and AlternateBridgeAuthority, see branch bug6377_rebased2.

Question is of course if it's wise to let testing networks talk to real HS authorities. I don't know.

Hmm. It'd be sweet if we could accept AlternateDirAuthority with the "hs" flag set as the equivalent of AlternateHSAuthority being set.

Replying to ln5:

Question is of course if it's wise to let testing networks talk to real HS authorities. I don't know.

‘HS authorities’ are not used at all by Tor 0.2.2.x and later.

Cherry-picked into 0.2.3.x; thanks!

Trac:
Status: needs_review to closed
Resolution: N/A to fixed

Trac:
Keywords: N/A deleted, tor-relay added

Trac:
Component: Tor Relay to Tor

closed

moved to tpo/core/tor#6377 (closed)