Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#6388 closed defect (fixed)

MIT ruleset is broken (and caused UI crashes in FF 16!)

Reported by: cypherpunks Owned by: MB
Priority: High Milestone:
Component: HTTPS Everywhere/EFF-HTTPS Everywhere Version:
Severity: Keywords: MIT
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

I am using FFx Nightly (16.0a1) and HTTPS Everywhere, in which I have disabled the rule for MIT. I have the following bookmark: http://mitpress.mit.edu/sicp/

When I try to load it, the address becomes https://mitpress$3.mit.edu/sicp/ and FFx says there was a problem loading the page. This happens with both HTTPS Everywhere 2.1 and 3.0b5, and on both Windows and Linux.

The Troubleshooting Information from my Firefox install is available here: http://pastebin.com/q8ssEbGq

I will be monitoring this ticket; please ask questions if any.

Child Tickets

Change History (6)

comment:1 Changed 6 years ago by pde

Status: newaccepted
Summary: [FFx] HTTPS Everywhere corrupts MIT URL even with disabled ruleMore UI breakage in recent Firefoxes

This exception is causing the UI code to die:

Timestamp: 07/13/2012 07:20:12 PM
Error: NS_ERROR_FAILURE: Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIURI.host]
Source File: chrome://https-everywhere/content/code/HTTPSRules.js
Line: 445


We need to check to see whether this is in FF 15 as well.

comment:2 Changed 6 years ago by pde

(There's also a bug in the MIT ruleset, of course)

comment:3 Changed 6 years ago by pde

My hypothesis is that the weird illegal hostname produced by this ruleset bug is being treated differently in FF16 than it is in slightly older FF versions. The different treatment is causing an internal exception that crashes the HTTPS Everywhere UI.

comment:4 Changed 6 years ago by pde

Owner: changed from pde to MB
Status: acceptedassigned
Summary: More UI breakage in recent FirefoxesMIT ruleset is broken (and caused UI crashes in FF 16!)

Hypothesis confirmed. The UI crash is fixed in this commit.

I'm handing the second portion of this bug over to MB to fix that crazy regexp in MIT.xml. I recommend splitting it into several <rules> so that they're sane and legible ;)

comment:5 Changed 6 years ago by MB

Resolution: fixed
Status: assignedclosed

Ruleset fixed in ce848.

comment:6 Changed 6 years ago by cypherpunks

Hello! Is the fix for these two issues going to be officially released anytime soon?

Note: See TracTickets for help on using tickets.