Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#6397 closed defect (fixed)

Correctly set bad_since on actually disabled nodes

Reported by: nickm Owned by:
Priority: High Milestone: Tor: 0.2.3.x-final
Component: Core Tor/Tor Version: Tor: 0.2.3.17-beta
Severity: Keywords: tor-client
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

This is Coverity 709599: the check in circuitbuild.c around 4749 that does:

     if (node->path_bias_disabled && !node->bad_since)
       node->bad_since = time(NULL);

is incorrect: It needs to refer to "e", not "node".

This could lead to path_bias_disabled nodes not getting disabled, or to crashes when using path bias disable thresholds.

Child Tickets

Change History (3)

comment:1 Changed 7 years ago by nickm

Resolution: fixed
Status: newclosed

Committed a trivial fix as 93b730175566de2dc

comment:2 Changed 7 years ago by nickm

Keywords: tor-client added

comment:3 Changed 7 years ago by nickm

Component: Tor ClientTor
Note: See TracTickets for help on using tickets.