Opened 7 years ago

Closed 7 years ago

Last modified 4 years ago

#6405 closed enhancement (implemented)

Merge torclient/torrelay/torbridge/etc into one Tor component

Reported by: arma Owned by: nickm
Priority: Medium Milestone:
Component: Internal Services/Service - trac Version:
Severity: Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Nick has been asking for a long time now for us to make a single Tor component, and use keywords to mark them as TorClient, TorBridge, etc. Using different components to describe what sort of Tor category a ticket is for drives him nuts.

Roger and Robert were pushing back because trac's search feature is abysmal, and our way of finding a ticket was to guess its Tor component and then look at the list of tickets under that component. But we should be able to do the same thing just narrowing by keyword.

Ultimately, since Nick is the primary user of this component, I think it makes the most sense to let him pick the conventions.

Child Tickets

Change History (8)

comment:1 Changed 7 years ago by arma

Owner: changed from erinn to nickm
Status: newassigned

comment:2 Changed 7 years ago by arma

We should come up with a description for how the new policy ought to work. For examples:

  • Do we enumerate a set of TorClient, TorBridge, TorHS, TorAuthority, etc keywords that we stick to? I worry that using keywords like "bridges" will result in helpful-but-confused users doing confusing things. On the other hand, having funny-looking component names will cause confusion among users and we'll always have to be fixing tickets. On the gripping hand, we'll probably be having to fix tickets anyway.
  • Is it reasonable to claim that a Tor-component ticket that doesn't have one of these keywords is flawed and should be fixed?
  • Where do we write down our intended plans in a way that bug-reporting users might find them?
  • What should we call the new megacomponent? "Tor"?

You should ask Karsten about his recent experience with doing mass trac changes.

comment:3 Changed 7 years ago by nickm

I propose "tor-client", "tor-hs", "tor-relay", "tor-auth", and "tor-bridge" as the tagnames.

"Tor" is a good megacomponent name.

I propose that we also add a saved query for "Things in tor without one of the tor-* tags", and that we consider such components in need of such a tag.

I suggest we write up a description of how we use trac's fields, and document it, and link it from the new-bugs page. Though we should still expect to do some triage on incoming bugs.

comment:4 in reply to:  2 Changed 7 years ago by karsten

Replying to arma:

You should ask Karsten about his recent experience with doing mass trac changes.

Happy to do the mass ticket changes here. Just let me know.

If you prefer to do it yourself, here's how: grant yourself TICKET_BATCH_MODIFY permissions, run a custom ticket query, select all tickets to change, click on "Batch Modify" at the bottom, select fields to change from "Add Field" drop-down box, enter new field values, add a comment, deselect "Send E-Mail Notifications", check that everything looks good, hit "Change tickets".

comment:5 Changed 7 years ago by nickm

Okay, no objections in 3 months here. If there are no objections RSN, I'm going to go ahead and do it.

comment:6 Changed 7 years ago by nickm

In progress. I've run into a little difficulty with batch-modifying "Tor Client" and "Tor Relay" -- unclear whether this is a "too many tickets" thing or an "old tickets" thing.

comment:7 Changed 7 years ago by nickm

Resolution: implemented
Status: assignedclosed

Okay, I think I'm done. Everything open with component "Tor" has a keyword; all the reports have been updated; everything has component "Tor" that should; there's now a report that lists all open tickets with component tor that lack one of the magic keywords.

comment:8 Changed 4 years ago by qbi

Component: TracService - trac

Move all tickets from trac to "Service - trac" component.

Note: See TracTickets for help on using tickets.