Opened 12 years ago

Last modified 7 years ago

#641 closed defect (Fixed)

asking to exit from yourself launches many circuits

Reported by: arma Owned by:
Priority: Low Milestone: post 0.2.0.x
Component: Core Tor/Tor Version: 0.2.0.22-rc
Severity: Keywords:
Cc: arma, nickm Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

sebastian hahn reports that if you ask to exit via yourself, using the .exit
notation, it will launch dozens of circuits.

My guess is that it's noticing, each second, that it doesn't have any suitable
circuits for the .exit stream, so it launches a new one.

There's something wrong with recognizing that the in-progress circuits are
acceptable for the pending stream.

My guess is it has to do with not having our descriptor in the router list.
See connection_ap_can_use_exit() where we ask
if (router_get_by_nickname(conn->chosen_exit_name, 1) != exit)

[Automatically added by flyspray2trac: Operating System: All]

Child Tickets

Change History (11)

comment:1 Changed 12 years ago by arma

this is repeatable for you right?

In connection_ap_can_use_exit(), look at the lines

log_debug(LD_APP,"Requested node '%s', considering node '%s'. No.",
conn->chosen_exit_name, exit->nickname);

If you uncomment those and rebuild, do you get a bunch of debug-level lines
like that when you trigger the bug?

comment:2 Changed 12 years ago by arma

arma, I get tons of "Mar 25 01:35:05.649 [debug]
connection_ap_can_use_exit(): Requested node 'fluxe2', considering node
'fluxe2'. No."

comment:3 Changed 12 years ago by Sebastian

Yep, I get that line repeated more than 100,000 times per connection attempt. Anything else I can do?

comment:4 Changed 12 years ago by arma

Does r14281 help?

comment:5 Changed 12 years ago by Sebastian

No, in case, this introduced bug #650

comment:6 Changed 12 years ago by Sebastian

one comment above should read "No, in fact, I believe it has introduced bug #650"

comment:7 Changed 12 years ago by nickm

I think r14297 fixes this and bug 650.

comment:8 Changed 12 years ago by Sebastian

I agree

comment:9 Changed 12 years ago by arma

Backported in r14311. Going to call this fixed now.

comment:10 Changed 12 years ago by arma

flyspray2trac: bug closed.

comment:11 Changed 7 years ago by nickm

Component: Tor RelayTor
Note: See TracTickets for help on using tickets.