Opened 7 years ago

Closed 4 years ago

#6433 closed defect (fixed)

Assure patching source succeeded

Reported by: Shondoit Owned by: erinn
Priority: Medium Milestone:
Component: Applications/Tor bundles/installation Version:
Severity: Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

In the TBB makefiles, target dirs are created before the make target is actually finished.
Hence, when patching fails, and the target is rerun, it sees the dir and happily continues on without patches.

Attached patch will unpack to a temp dir and only rename the folders when patching succeeded, thus ensuring we always have patched sources.

Child Tickets

Attachments (1)

0001-Unpack-sources-to-temporary-dirs.patch (6.7 KB) - added by Shondoit 7 years ago.

Download all attachments as: .zip

Change History (3)

Changed 7 years ago by Shondoit

comment:1 Changed 7 years ago by Shondoit

Status: newneeds_review

Just to clarify, this is currently untested on Linux and OSX, therefore -> needs_review actually means needs review.

comment:2 Changed 4 years ago by cypherpunks

Resolution: fixed
Status: needs_reviewclosed

This is patch for Scripts to build the Tor Browser Bundles (old, pre 3.x)
Closing as fixed, please create a new ticket if it's still an issue for gitian-builder scripts.

Note: See TracTickets for help on using tickets.