Opened 7 years ago

Last modified 2 years ago

#6504 needs_information enhancement

Support Windows environment variables in HiddenServiceDir

Reported by: criticoder Owned by:
Priority: Low Milestone: Tor: unspecified
Component: Core Tor/Tor Version: Tor: 0.2.2.36
Severity: Normal Keywords: windows, intro, tor-hs, torrc config
Cc: wearenotamused@… Actual Points:
Parent ID: Points: 5
Reviewer: Sponsor:

Description

Expansion should be done each time the hidden service dir is opened, and stored unexpanded. Actually, my impression is that if you use the right Win32 API calls to open the location, tor itself doesn't need to worry about expansion. Win32 will take care of any necessary.

One direct benefit to you devs is that you could then use '%UserProfile%' in the HiddenServiceDir examples for Windows in your documentation, such as the one discussed in #4798, yielding the appropriate location in every version that Tor supports.

This behavior could/should eventually broadened to all options for which a path can be specified (e.g. DataDirectory, GeoIPFile, PidFile), so if the fix would affect the opening of other paths (I haven't looked through the source code), all the better. If the fix isn't in a core function, I'd be happy to add a new, broader, ticket.

P.S. The version I'm using is actually 0.2.2.37, but I don't see it in the list.

Child Tickets

Change History (11)

comment:1 Changed 7 years ago by criticoder

Cc: wearenotamused@… added

comment:2 Changed 7 years ago by nickm

Milestone: Tor: unspecified

Potentially interesting! Anybody want to research the right APIs here?

comment:3 Changed 7 years ago by nickm

Keywords: tor-hs added

comment:4 Changed 7 years ago by nickm

Component: Tor Hidden ServicesTor

comment:5 Changed 4 years ago by dgoulet

Keywords: windows intro added; environment variables HiddenServiceDir removed
Milestone: Tor: unspecifiedTor: 0.2.???
Points: medium
Priority: MediumLow
Severity: Normal

comment:6 Changed 3 years ago by teor

Milestone: Tor: 0.2.???Tor: 0.3.???

Milestone renamed

comment:7 Changed 3 years ago by nickm

Keywords: tor-03-unspecified-201612 added
Milestone: Tor: 0.3.???Tor: unspecified

Finally admitting that 0.3.??? was a euphemism for Tor: unspecified all along.

comment:8 Changed 2 years ago by nickm

Keywords: tor-03-unspecified-201612 removed

Remove an old triaging keyword.

comment:9 Changed 2 years ago by nickm

Keywords: torrc config added
Points: medium5
Resolution: wontfix
Status: newclosed

Hm, I just closed #5208, which is very similar, but maybe this ticket is sufficient motivation to re-open #5208.

Then again, no activity here in 5 years. Is this something that windows folks would actually use?

comment:10 Changed 2 years ago by nickm

Resolution: wontfix
Status: closedreopened

comment:11 Changed 2 years ago by nickm

Status: reopenedneeds_information
Note: See TracTickets for help on using tickets.