#6517 closed enhancement (fixed)
Redundant calls to check_sockaddr_family_match in connection_handle_listener_read
| Reported by: | sysrqb | Owned by: | |
|---|---|---|---|
| Priority: | Very Low | Milestone: | Tor: 0.2.4.x-final |
| Component: | Core Tor/Tor | Version: | |
| Severity: | Keywords: | tor-client | |
| Cc: | Actual Points: | ||
| Parent ID: | Points: | ||
| Reviewer: | Sponsor: |
Description
check_sockaddr_family_match is called twice without an apparent reason. It should be reasonable to remove the second instance assuming check_sockaddr does not modify *remote (constifying ticket coming soon).
Child Tickets
Attachments (1)
Change History (6)
comment:1 Changed 8 years ago by
| Priority: | minor → trivial |
|---|---|
| Status: | new → needs_revision |
Changed 8 years ago by
| Attachment: | 0001-Removed-redundant-check_sockaddr_family_match-call.patch added |
|---|
comment:2 Changed 8 years ago by
| Status: | needs_revision → needs_review |
|---|
comment:3 Changed 8 years ago by
| Milestone: | → Tor: 0.2.4.x-final |
|---|---|
| Resolution: | → fixed |
| Status: | needs_review → closed |
Merged; thanks!
comment:4 Changed 8 years ago by
| Keywords: | tor-client added |
|---|
comment:5 Changed 8 years ago by
| Component: | Tor Client → Tor |
|---|
Note: See
TracTickets for help on using
tickets.
Patch can be pulled from git://gitweb.evolvesoftware.cc/tor.git bug6517 or use attached patch.