Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#6517 closed enhancement (fixed)

Redundant calls to check_sockaddr_family_match in connection_handle_listener_read

Reported by: sysrqb Owned by:
Priority: Very Low Milestone: Tor: 0.2.4.x-final
Component: Core Tor/Tor Version:
Severity: Keywords: tor-client
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:


check_sockaddr_family_match is called twice without an apparent reason. It should be reasonable to remove the second instance assuming check_sockaddr does not modify *remote (constifying ticket coming soon).

Child Tickets

Attachments (1)

0001-Removed-redundant-check_sockaddr_family_match-call.patch (838 bytes) - added by sysrqb 8 years ago.

Download all attachments as: .zip

Change History (6)

comment:1 Changed 8 years ago by sysrqb

Priority: minortrivial
Status: newneeds_revision

Patch can be pulled from git:// bug6517 or use attached patch.

comment:2 Changed 8 years ago by sysrqb

Status: needs_revisionneeds_review

comment:3 Changed 8 years ago by nickm

Milestone: Tor: 0.2.4.x-final
Resolution: fixed
Status: needs_reviewclosed

Merged; thanks!

comment:4 Changed 8 years ago by nickm

Keywords: tor-client added

comment:5 Changed 8 years ago by nickm

Component: Tor ClientTor
Note: See TracTickets for help on using tickets.