Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#6518 closed enhancement (fixed)

Checking for sanity should not change incoming socket in check_sockaddr

Reported by: sysrqb Owned by:
Priority: Very Low Milestone:
Component: Core Tor/Tor Version:
Severity: Keywords: tor-client
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

From talking with asn, we should constify struct sockaddr *sa so that we can ensure #6517 holds true.

check_sockaddr(struct sockaddr *sa, int len, int level) changes to check_sockaddr(const struct sockaddr *sa, int len, int level)

Child Tickets

Attachments (1)

0001-Constify-struct-sockaddr-sa-parameter-for-check.patch (826 bytes) - added by sysrqb 7 years ago.

Download all attachments as: .zip

Change History (5)

comment:1 Changed 7 years ago by sysrqb

Status: newneeds_review

Patch can be pulled from git://gitweb.evolvesoftware.cc/tor.git bug6518 or use attached patch.

comment:2 Changed 7 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

Merged; thanks!

comment:3 Changed 7 years ago by nickm

Keywords: tor-client added

comment:4 Changed 7 years ago by nickm

Component: Tor ClientTor
Note: See TracTickets for help on using tickets.