Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#6522 closed enhancement (implemented)

[PATCH] Enable automake silent rules

Reported by: stewart Owned by: stewart
Priority: Medium Milestone: Tor: 0.2.4.x-final
Component: Core Tor/Tor Version: Tor: unspecified
Severity: Keywords: tor-client
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

two patches to enable automake silent rules by default for build, including documentation builds (second patch).

This makes it easier to see compiler warnings.

As usual, it can be disabled with "make V=1" for any specific invocation of make

Child Tickets

Attachments (3)

01-enable_silent_rules.patch (693 bytes) - added by stewart 7 years ago.
02-silent-rules-for-docs.patch (1.8 KB) - added by stewart 7 years ago.
03-support-ancient-automake.patch (589 bytes) - added by stewart 7 years ago.

Download all attachments as: .zip

Change History (12)

Changed 7 years ago by stewart

Changed 7 years ago by stewart

comment:1 Changed 7 years ago by arma

Component: - Select a componentTor Client
Milestone: Tor: 0.2.4.x-final
Status: newneeds_review

comment:2 Changed 7 years ago by ioerror

Thanks for the patch!

I'm a fan of mostly silent compiles - it makes it way easier to spot compiler warnings. I'm all for this change.

comment:3 Changed 7 years ago by stewart

I'm having a go at moving tor to non recursive Make. This will make it even cleaner.

I'm assuming that at least automake-1.11 is already required, otherwise i can massage it to support ancient automake.

comment:4 in reply to:  3 ; Changed 7 years ago by arma

Replying to stewart:

I'm assuming that at least automake-1.11 is already required, otherwise i can massage it to support ancient automake.

Which automakes do we support currently? From the Tor 0.2.1.29 ChangeLog,

  o Build changes:
    - Tor does not build packages correctly with Automake 1.6 and earlier;
      added a check to Makefile.am to make sure that we're building with
      Automake 1.7 or later.

We like being able to build on crazy and wild systems. It's all a tradeoff of course, but we'll be much more sad giving up flexibility in exchange for more cleanliness.

comment:5 in reply to:  4 Changed 7 years ago by stewart

Replying to arma:

Replying to stewart:
Which automakes do we support currently? From the Tor 0.2.1.29 ChangeLog,

o Build changes:
- Tor does not build packages correctly with Automake 1.6 and earlier;
added a check to Makefile.am to make sure that we're building with
Automake 1.7 or later.

We like being able to build on crazy and wild systems. It's all a tradeoff of course, but we'll be much more sad giving up flexibility in exchange for more cleanliness.

I'll attach 03-support-ancient-automake.patch which will enabled the silent mode conditionally only if automake has the needed macro. I haven't tested the rest of the Tor automake to see if it actually works on old automake, but this patch will at least make the silent rules only be active if they exist.

Changed 7 years ago by stewart

comment:6 Changed 7 years ago by nickm

Resolution: implemented
Status: needs_reviewclosed

Merged; tested with automake-1.7; seems to work ok. Thanks!

For the record, next time, could you use "git format-patch" to generate patch files? It looks like you used "git show" or something, which I can't automatically merge with "git am" or anything.

comment:7 in reply to:  6 Changed 7 years ago by stewart

Replying to nickm:

Merged; tested with automake-1.7; seems to work ok. Thanks!

For the record, next time, could you use "git format-patch" to generate patch files? It looks like you used "git show" or something, which I can't automatically merge with "git am" or anything.

My git foo is a bit out of date and rusty, thanks for the pointer. Done for my next set: https://trac.torproject.org/projects/tor/ticket/6524

comment:8 Changed 7 years ago by nickm

Keywords: tor-client added

comment:9 Changed 7 years ago by nickm

Component: Tor ClientTor
Note: See TracTickets for help on using tickets.