Opened 7 years ago

Closed 7 years ago

Last modified 22 months ago

#6541 closed enhancement (fixed)

Make Decentralized SSL Observatory / Tor interoperability sane again

Reported by: pde Owned by: mikeperry
Priority: Immediate Milestone:
Component: HTTPS Everywhere/EFF-HTTPS Everywhere Version:
Severity: Normal Keywords: MikePerry201208
Cc: Actual Points: 3
Parent ID: Points: 3
Reviewer: Sponsor:

Description

The Decentralized SSL Observatory has an option to use Tor (via Torbutton) for strongly anonymised submissions of X.509 certs. Unfortunately, when Torbutton switched to being "always on", users lost the ability to use the Observatory all the time with Tor acting as the background submission method.

So what we should do is pull the components out of Torbutton that detect a local Tor instance, see if the regular and Tor Browser Bundle Tor proxy ports are open, ping check.torproject.org over those, and determine whether Tor is locally available that way.

I will also replace "Torbutton" with "Tor" in the UI when that patch is ready.

(This is blocking 3.0 stable, because all of the advice in the UI about Tor and the Observatory is currently weird/wrong, and lots more people will see that advice when 3.0 stable ships)

Child Tickets

Change History (5)

comment:1 Changed 7 years ago by pde

Mike if you can get the Torbutton component imports to a sensible point, I will make the probes work asynchronously, and delay the renderability of the SSL Observatory UI until we know whether Tor is or isn't present.

comment:2 Changed 7 years ago by mikeperry

Keywords: MikePerry201208 added

comment:3 Changed 7 years ago by mikeperry

I have a commit in mikeperry/observatory-tortest that makes the observatory test for Tor and use it if it finds it. It seems to work, but I haven't touched the UI at all yet though... I'm not sure the best way to delay the dialog, since it is fairly decoubled from the XPCOM component.

I suppose I could do something ghetto like have the UI dialog register a callback to get called when the test completes...

comment:4 Changed 7 years ago by mikeperry

Actual Points: 3
Points: 3
Resolution: fixed
Status: newclosed
Type: taskenhancement

Ok, the UI popup delay is now done. I've tested both system tor present and system tor absent cases and both seem to be working OK. The delayed popup is a little weird.. Sometimes it takes a couple seconds after startup to appear, especially if the system tor was idle and needs to build a fresh new circuit.

I also updated the observatory UI strings, so you'll want to refresh transifex.

comment:5 Changed 22 months ago by teor

Severity: Normal

Set all tickets without a severity to "Normal"

Note: See TracTickets for help on using tickets.