Opened 11 years ago

Last modified 7 years ago

#660 closed defect (Fixed)

swapped params in call to rep_hist_note_used_port

Reported by: aakova Owned by:
Priority: Low Milestone:
Component: Core Tor/Tor Version: 0.2.0.23-rc
Severity: Keywords:
Cc: aakova, arma Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

version: tor-0.2.0.23-rc

[tor/src/or/directory.c:directory_initiate_command:~722]

/* If it's an anonymized connection, remember the fact that we

  • wanted it for later: maybe we'll want it again soon. */

if (anonymized_connection && use_begindir)

rep_hist_note_used_internal(time(NULL), 0, 1);

else if (anonymized_connection && !use_begindir)

[ The parameters in the following call are swapped compared to the function declaration and
definintion. ]

rep_hist_note_used_port(time(NULL), conn->_base.port);

[tor/src/or.h:~3581]
void rep_hist_note_used_port(uint16_t port, time_t now);

[tor/src/or/rephist.c:~1426]

void
rep_hist_note_used_port(uint16_t port, time_t now)

[Automatically added by flyspray2trac: Operating System: All]

Child Tickets

Change History (5)

comment:1 Changed 11 years ago by arma

Nice bug!

Will fix shortly.

How did you run across it?

comment:2 Changed 11 years ago by aakova

[ built with microsoft vc++ 2005 ]

comment:3 Changed 11 years ago by arma

Fixed in r14375, r14376, and r14377. Thanks!

comment:4 Changed 11 years ago by arma

flyspray2trac: bug closed.

comment:5 Changed 7 years ago by nickm

Component: Tor RelayTor
Note: See TracTickets for help on using tickets.