Opened 7 years ago

Closed 7 years ago

#6616 closed enhancement (fixed)

Node Down - order of links, possible 'detail' link

Reported by: Spider.007 Owned by: kaner
Priority: Medium Milestone:
Component: Metrics/Tor Weather Version:
Severity: Keywords:
Cc: mo Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

This has happened a few times now, I wake up to find a 'Node Down' email from TorWeather. Anxious to find out what is wrong, I want to see if it is currently up or still down, so I click the first link in the email.... which is the unsubscribe link.

I would rather see both links (to preferences and unsubscribe) switched, because the first link in the message should not go to unsubscribe. A second feature request: would it be possible to include a link to http://atlas.torproject.org/#details in this email?

Child Tickets

Attachments (2)

0001-Swap-the-preferences-and-unsubscribe-links.patch (12.1 KB) - added by kraai 7 years ago.
Patch
0001-Link-to-the-atlas-router-page.patch (1.4 KB) - added by kraai 7 years ago.
Patch to link to atlas router page

Download all attachments as: .zip

Change History (11)

comment:1 Changed 7 years ago by arma

Good ideas.

I wonder who our tor weather maintainer is. If we still have one.

Patches are clearly best here. :)

comment:2 Changed 7 years ago by arma

Cc: mo added

(might be that kaner is still our maintainer, in which case, great. also, cc'ing moritz since he might want a hand in updating tor weather's behavior.)

comment:3 Changed 7 years ago by Spider.007

I wouldn't mind attempting to create a patch with my limited python skills, but I can't find the current version of the template. The text in https://svn.torproject.org/svn/weather/trunk/lib/weather/constants.py is not the same as the message that currently gets send out, so my patch against that would be useless

comment:4 in reply to:  3 Changed 7 years ago by karsten

Replying to Spider.007:

I wouldn't mind attempting to create a patch with my limited python skills, but I can't find the current version of the template. The text in https://svn.torproject.org/svn/weather/trunk/lib/weather/constants.py is not the same as the message that currently gets send out, so my patch against that would be useless

Just guessing, but maybe it's https://gitweb.torproject.org/weather.git? If it is, we should remove the content in the SVN repo and replace it with a README pointing to the Git repo.

comment:5 Changed 7 years ago by kraai

Status: newneeds_review

comment:6 Changed 7 years ago by kraai

I forgot about the second request in this ticket, so the patch doesn't do anything to address it.

Changed 7 years ago by kraai

Patch to link to atlas router page

comment:7 in reply to:  5 ; Changed 7 years ago by kaner

Replying to kraai:

Thanks for your patches.

One quick question: Why did you change the parameter order for all routines that use the auth keys, instead of simply changing the order of appearance in the text? (as you did in weather/weatherapp/emails.py, line 138)

comment:8 in reply to:  7 Changed 7 years ago by kraai

Replying to kaner:

One quick question: Why did you change the parameter order for all routines that use the auth keys, instead of simply changing the order of appearance in the text? (as you did in weather/weatherapp/emails.py, line 138)

I thought it would be a good idea to keep the order consistent between how they're used in the email and how they're passed around. If you'd prefer otherwise, I can submit a much shorter patch. :)

comment:9 Changed 7 years ago by kaner

Resolution: fixed
Status: needs_reviewclosed

No need for a new patch, I applied the one you already created, but only the necessary parts. Thanks again!

Note: See TracTickets for help on using tickets.