Opened 7 years ago

Closed 14 months ago

Last modified 13 months ago

#6620 closed defect (wontfix)

Vidalia does not disable proxy after "I use a proxy to access the Internet" is unchecked

Reported by: tor-onion Owned by: chiiph
Priority: Very High Milestone:
Component: Archived/Vidalia Version: Vidalia: 0.2.20
Severity: Keywords: archived-closed-2018-07-04
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Steps to reproduce


  1. Open Start Tor Browser.exe without any proxy defined in the settings (torrc file).
  2. Enter any proxy and any port, and select HTTP/HTTPS as the proxy type, and save the settings.
  3. Successfully connect to Tor.
  4. Close TorBrowser, therefore closing Vidalia.
  5. Restart Vidalia by opening Start Tor Browser.exe.
  6. Once Vidalia is open, immediately click "Stop Tor".
  7. Open up settings, disable the proxy by unchecking "I use a proxy to access the Internet" and click "OK".

Current Behavior
---
Tor still uses the proxy to connect to the Tor network.

Expected Behavior
---
Tor establishes a direct connection to the Tor network.

On a side note, the torrc file still has the proxy line, so I could just delete that particular line for now as a workaround. Looking forward to a fix.

Child Tickets

Attachments (1)

0001-Reload-Tor-after-external-connection-settings-change.patch (3.6 KB) - added by sysrqb 7 years ago.

Download all attachments as: .zip

Change History (7)

comment:1 Changed 7 years ago by sysrqb

This makes sense.

I think the only way to handle this is to start Tor, attach controller, apply new settings, reload Tor.

I'll start working on a patch but others' thoughts are welcome.

comment:2 Changed 7 years ago by sysrqb

Status: newneeds_review

Reload Tor after settings change on Network page while Vidalia is not connected to Tor. This patch specifically fixes this bug, but I'm not sure if it's necessary for changing bridge settings under the same circumstances, also (I have a feeling it is).

Branch bug6620 on git://gitweb.evolvesoftware.cc/vidalia.git and below.

Thoughts?

comment:3 Changed 7 years ago by chiiph

Status: needs_reviewneeds_revision

If Tor has been stopped, then it shouldn't be able to apply any kind of settings through torControl. Are you sure you tested it as the user specified?

If that previous statement is correct, then the point in here would be that the user shouldn't be able to modify settings that are applied through torControl unless it's connected to Tor. A possibility could be to disable the widgets and have a label that says "Start Tor to edit these options".

Fwiw, this issue is only present in current stable, the alpha branch works directly with the torrc, so it should be ok. Although it would be good to check that out.

comment:4 Changed 7 years ago by sysrqb

But the way I understand Vidalia to handle these changes is that while Tor is not running Vidalia write the changes out to its config and marks them as changed. Once Vidalia starts Tor and successfully connects to it, Vidalia sends the necessary commands to apply the new settings.

This is exactly how my tests show it to work...is this not how it was designed to work?

And for the alpha, is there an eta on it?

comment:5 in reply to:  4 Changed 7 years ago by chiiph

Status: needs_revisionneeds_review

Replying to sysrqb:

But the way I understand Vidalia to handle these changes is that while Tor is not running Vidalia write the changes out to its config and marks them as changed. Once Vidalia starts Tor and successfully connects to it, Vidalia sends the necessary commands to apply the new settings.

This is exactly how my tests show it to work...is this not how it was designed to work?

Right, I forgot about that, yes. I trust that your patch works, but I'm just confused about why starting Tor right after saving the settings is different from changing them, wait a few seconds, and press "Start Tor" (as the reporter seems to have done). Do you understand where my confusion comes from? It would be nice to understand why those settings saved in vidalia.conf and marked as unapplied to Tor don't get applied sometimes.

And for the alpha, is there an eta on it?

It's already good to go from my point of view, but there need to be at least one alpha release so that it gets properly tested before calling it stable.

comment:7 Changed 14 months ago by teor

Keywords: archived-closed-2018-07-04 added
Resolution: wontfix
Status: needs_reviewclosed

Close all tickets in archived components

Note: See TracTickets for help on using tickets.