Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#6621 closed defect (fixed)

Authorities shouldn't set Running unless all advertised OR ports are reachable

Reported by: ln5 Owned by: ln5
Priority: Medium Milestone: Tor: 0.2.4.x-final
Component: Core Tor/Tor Version:
Severity: Keywords: ipv6 tor-auth
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Prop 186 says

An authority shouldn't list a node as Running unless every
or-address line it advertises looks like it will work.

Authorities don't consider a potential IPv6 OR port when deciding
whether a relay is running or not.

I suggest we fix that but have auths not on IPv6
(AuthDirHasIPv6Connectivity == 0) not take IPv6 reachability into
account.

Child Tickets

Change History (6)

comment:1 Changed 7 years ago by ln5

Status: newneeds_review

Please review bug6621 in my repo.

comment:2 Changed 7 years ago by nickm

Milestone: Tor: 0.2.4.x-final

Looks good; though I think shouldn't go in until/unless authorities actually launch test connections to IPv6 addresses. Do they?

comment:3 in reply to:  2 Changed 7 years ago by ln5

Replying to nickm:

Looks good; though I think shouldn't go in until/unless authorities actually launch test connections to IPv6 addresses. Do they?

We do the dirserv_single_reachability_test() thing on IPv6 OR ports
since commit 4cce8ab7 (Wed May 9). My tests indicates that's enough to
get the Running flag.

comment:4 Changed 7 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

Okay; merged!

comment:5 Changed 7 years ago by nickm

Keywords: tor-auth added

comment:6 Changed 7 years ago by nickm

Component: Tor Directory AuthorityTor
Note: See TracTickets for help on using tickets.