Opened 6 years ago

Closed 6 years ago

#6653 closed defect (fixed)

A bug in checkForBuggyDefaults causes settings to be lost on browser restart

Reported by: federico Owned by: pde
Priority: High Milestone:
Component: HTTPS Everywhere/EFF-HTTPS Everywhere Version: HTTPS-E 2.2.1
Severity: Keywords: rules disable
Cc: schoen, wroberts@…, shawnmtaylor@…, fiacca.m@… Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

I've disabled some rules (youtube and slideshare)

despite that, every time I restart firefox, rules are enabled

since 3.0development.6, disabled rules remained disabled even at firefox restart

Child Tickets

Attachments (1)

checkForBuggyDefaults.patch (715 bytes) - added by federico 6 years ago.
the solving patch

Download all attachments as: .zip

Change History (8)

comment:1 Changed 6 years ago by federico

Summary: laster master eeffa553bbb50bb0b375e1c969f014a6c4b3a841 forgets disabled rulescheckForBuggyDefaults has wrong for loop

after some debugging, I've found the "for (rulename in shouldBeOff)" is wrong as "for...in" iterates over the index of the array
the bug caused https everywhere to always reset the active status of all rules

Changed 6 years ago by federico

Attachment: checkForBuggyDefaults.patch added

the solving patch

comment:2 Changed 6 years ago by pde

Cc: schoen added

Thanks for the patch federico. I've been on vacation, but we'll apply this and push a new version today or tomorrow.

comment:3 Changed 6 years ago by pde

Closing #6646 and #6689, which were duplicates of this bug.

comment:4 Changed 6 years ago by pde

Version: HTTPS-E 2.2.1

comment:5 Changed 6 years ago by pde

Cc: wroberts@… shawnmtaylor@… fiacca.m@… added
Status: newaccepted
Summary: checkForBuggyDefaults has wrong for loopA bug in checkForBuggyDefaults causes settings to be lost on browser restart

Adding CCs to the people who sent messages to the mailing list about this.

comment:6 Changed 6 years ago by pde

The fix is in git and will be out in 2.2.2 shortly.

comment:7 Changed 6 years ago by pde

Resolution: fixed
Status: acceptedclosed

This is fixed in 2.2.2

Note: See TracTickets for help on using tickets.