Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#6665 closed defect (fixed)

build: upgrade soon-to-be-obsolete automake usage

Reported by: meyering Owned by:
Priority: Medium Milestone: Tor: unspecified
Component: Core Tor/Tor Version:
Severity: Keywords: tor-relay
Cc: jim@… Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Building with built-from-git automake now fails.
Patch attached. Here's the commit log:

Starting with upcoming automake-1.13, AM_INIT_AUTOMAKE will accept
only one argument, and the old 2-or-more argument form
as used here will be rejected. Instead, use autoconf's
AC_INIT macro to record the package name and version.
Similarly use autoconf's AC_CONFIG_HEADERS macro in place
of automake's obsolete AM_CONFIG_HEADER macro.

In addition, teach contrib/updateVersions.pl how to extract
version string, given the modernized macro usage.

Child Tickets

Attachments (1)

tor-build-vs-automake.diff (2.1 KB) - added by meyering 7 years ago.
[PATCH] build: upgrade soon-to-be-obsolete automake usage

Download all attachments as: .zip

Change History (9)

Changed 7 years ago by meyering

Attachment: tor-build-vs-automake.diff added

[PATCH] build: upgrade soon-to-be-obsolete automake usage

comment:1 Changed 7 years ago by nickm

I think a patch for this is also included in #6524.

comment:2 Changed 7 years ago by nickm

Milestone: Tor: unspecified

comment:3 Changed 7 years ago by meyering

You're right. Here's the patch that includes it:

https://trac.torproject.org/projects/tor/attachment/ticket/6524/04-non-recursive-make.patch

Are you inclined to integrate the non-recursive make patches? (very nice
that people are switching to that, btw) I was inspired by bison's conversion
and converted cppi, as a proof of concept. If someone were to volunteer high-quality
patches for projects I tend (gzip, grep, diff, coreutils), I would apply them in a flash.

Are the patches for 6524 already applied to some branch? If so, I'd be happy to ensure
that they work with the very latest automake and autoconf.

Anyway, feel free to close this.

comment:4 in reply to:  3 Changed 7 years ago by nickm

Replying to meyering:

You're right. Here's the patch that includes it:

https://trac.torproject.org/projects/tor/attachment/ticket/6524/04-non-recursive-make.patch

Are you inclined to integrate the non-recursive make patches? (very nice
that people are switching to that, btw)

Yes, but read the discussion thread at #6524: there is a lingering bug on the latest version that makes breaks the build for me. It needs to get fixed before I could merge those patches.

comment:5 Changed 7 years ago by meyering

Actually, now that I've looked more closely, I see part of my change is *not* included in that patch:

-AM_CONFIG_HEADER(orconfig.h)
+AC_CONFIG_HEADERS([orconfig.h])

Without that, autogen.sh fails (with my built-from-git automake/master):

$ ./autogen.sh
autoreconf: Entering directory `.'
autoreconf: configure.in: not using Gettext
autoreconf: running: aclocal --force
configure.in:10: warning: macro 'AM_CONFIG_HEADER' not found in library
autoreconf: configure.in: tracing
autoreconf: configure.in: not using Libtool
autoreconf: running: /p/bin/autoconf --force
configure.in:10: error: possibly undefined macro: AM_CONFIG_HEADER

If this token and others are legitimate, please use m4_pattern_allow.
See the Autoconf documentation.

autoreconf: /p/bin/autoconf failed with exit status: 1
[Exit 1]

comment:6 Changed 7 years ago by nickm

Resolution: fixed
Status: newclosed

Looks like that line got merged in 0df149ff. Thanks!

comment:7 Changed 7 years ago by nickm

Keywords: tor-relay added

comment:8 Changed 7 years ago by nickm

Component: Tor RelayTor
Note: See TracTickets for help on using tickets.