Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#6667 closed defect (fixed)

SETCIRCUITPURPOSE's format in the control spec is misleading

Reported by: neena Owned by: neena
Priority: Very Low Milestone:
Component: Core Tor/Tor Version:
Severity: Keywords: tor-client
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

From the control spec...

 761 3.11. SETCIRCUITPURPOSE
 762 
 763   Sent from the client to the server.  The format is:
 764       "SETCIRCUITPURPOSE" SP CircuitID SP Purpose CRLF
 765 
 766   This changes the circuit's purpose. See EXTENDCIRCUIT above for details.

And from 'EXTENDCIRCUIT above'...

3.10. EXTENDCIRCUIT
 736 
 737   Sent from the client to the server.  The format is:
 738       "EXTENDCIRCUIT" SP CircuitID
 739                       [SP ServerSpec *("," ServerSpec)]
 740                       [SP "purpose=" Purpose] CRLF

This seems to imply that "SETCIRCUITPURPOSE 4 controller" is valid, but, it isn't, "SETCIRCUITPURPOSE 4 purpose=controller" is.

 764       "SETCIRCUITPURPOSE" SP CircuitID SP Purpose CRLF

should be...

 764       "SETCIRCUITPURPOSE" SP CircuitID SP "purpose=" Purpose CRLF

I'm attaching a git formatted patch which makes this modification.

Child Tickets

Attachments (1)

0001-Fix-misleading-SETCIRCUITPURPOSE-format.patch (743 bytes) - added by neena 8 years ago.

Download all attachments as: .zip

Change History (7)

comment:1 Changed 8 years ago by neena

Owner: set to neena
Status: newassigned

comment:2 Changed 8 years ago by neena

Status: assignedneeds_review

comment:3 Changed 8 years ago by neena

Priority: normaltrivial

comment:4 Changed 8 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

applied; thanks!

comment:5 Changed 8 years ago by nickm

Keywords: tor-client added

comment:6 Changed 8 years ago by nickm

Component: Tor ClientTor
Note: See TracTickets for help on using tickets.