Opened 7 years ago

Closed 20 months ago

#6677 closed enhancement (wontfix)

Add a 'total' line at the bottom of the table

Reported by: cypherpunks Owned by: metrics-team
Priority: Medium Milestone:
Component: Metrics/Compass Version:
Severity: Normal Keywords:
Cc: gsathya Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Please add a bottom line at the table that sums up all entries in the table. This is useful in different occasions (i.e. viewing all relays of a country).

Child Tickets

Change History (12)

comment:1 Changed 7 years ago by karsten

Cc: gsathya added

Agreed. The command-line version of Compass has a line with totals and even a line with other results that didn't make it into the top-X displayed rows. Here's an example:

$ ./compass.py -c de -s
       CW    adv_bw   P_guard  P_middle    P_exit Nickname            
  3.2489%   0.9681%   2.7937%   2.7933%   4.1591% chaoscomputerclub18 
  1.8749%   0.8986%   1.6122%   1.6120%   2.4001% chaoscomputerclub19 
  1.4639%   1.0187%   1.2588%   1.2587%   1.8741% chaoscomputerclub20 
  1.3098%   0.7024%   0.0000%   0.0000%   3.9297% chaoscomputerclub5  
  1.2970%   0.5277%   0.0000%   0.0000%   3.8912% bouazizi            
  1.2482%   0.7187%   0.0000%   0.0000%   3.7448% chaoscomputerclub3  
  1.1275%   0.9684%   0.9695%   0.9694%   1.4434% chaoscomputerclub21 
  0.8103%   0.4919%   0.0000%   0.0000%   2.4310% raskin              
  0.7140%   0.2575%   0.0000%   0.0000%   2.1421% SUPERVDS02          
  0.6305%   0.3197%   1.1882%   0.7035%   0.0000% PPrivCom013         
 14.9169%  16.9052%  18.2765%  17.4087%   9.0666% (557 other relays)
 28.6420%  23.7769%  26.0988%  24.7455%  35.0820% (total in selection)

In theory, we could add these two lines to the website results, too. Not sure how hard this is. Sathya, what do you think?

comment:2 in reply to:  1 Changed 7 years ago by gsathya

Status: newneeds_information

Replying to karsten:

In theory, we could add these two lines to the website results, too. Not sure how hard this is. Sathya, what do you think?

Do we want this info inside the table? Add '-' for the rest of the entries?

comment:3 Changed 7 years ago by karsten

Yes, I'd say inside the table. Is there some concept of a table footer that we could use here, which looks different than the normal table rows? Also, I'd leave empty cells blank rather than writing '-'. But these are all details we can tweak later. :)

comment:4 Changed 7 years ago by gsathya

Status: needs_informationneeds_review

Please review my bug_6677 branch. Thanks!

comment:5 Changed 7 years ago by karsten

Status: needs_reviewneeds_revision

Looks good, except that "(18 othe" and "(total i" in the fingerprint column are cut off.

Also, I wonder if there are any design guidelines for table footers. Simply adding two more rows works, but there must be prettier ways. How do other sites format table footers containing summaries?

comment:6 in reply to:  5 ; Changed 7 years ago by gsathya

Status: needs_revisionneeds_review

Replying to karsten:

Looks good, except that "(18 othe" and "(total i" in the fingerprint column are cut off.

Damn! I thought I fixed this. Sorry! Please fixup c90add1 when you merge. Thanks!

Also, I wonder if there are any design guidelines for table footers. Simply adding two more rows works, but there must be prettier ways. How do other sites format table footers containing summaries?

Googling turned up with this - https://forrst-production.s3.amazonaws.com/posts/snaps/136973/original.png?1332675932
It looks pretty, but I have no idea how to implement the CSS. I'll try playing around with it a bit.

comment:7 in reply to:  6 ; Changed 7 years ago by karsten

Status: needs_reviewneeds_revision

Replying to gsathya:

Replying to karsten:

Looks good, except that "(18 othe" and "(total i" in the fingerprint column are cut off.

Damn! I thought I fixed this. Sorry! Please fixup c90add1 when you merge. Thanks!

Hmm, no, that didn't fix the issue for me. I wonder why. Also, maybe you could rebase to current master? I'm afraid I'll break something when doing that.

Oh, and I just found that "(total i" is a link to Atlas, which doesn't really make sense. Can you take that out, too?

Also, I wonder if there are any design guidelines for table footers. Simply adding two more rows works, but there must be prettier ways. How do other sites format table footers containing summaries?

Googling turned up with this - https://forrst-production.s3.amazonaws.com/posts/snaps/136973/original.png?1332675932
It looks pretty, but I have no idea how to implement the CSS. I'll try playing around with it a bit.

Looks good.

comment:8 in reply to:  7 ; Changed 7 years ago by gsathya

Status: needs_revisionneeds_review

Replying to karsten:

Hmm, no, that didn't fix the issue for me. I wonder why. Also, maybe you could rebase to current master? I'm afraid I'll break something when doing that.

Oh, and I just found that "(total i" is a link to Atlas, which doesn't really make sense. Can you take that out, too?

Done. https://github.com/gsathya/compass/compare/bug_6677

Googling turned up with this - https://forrst-production.s3.amazonaws.com/posts/snaps/136973/original.png?1332675932
It looks pretty, but I have no idea how to implement the CSS. I'll try playing around with it a bit.

Looks good.

Ok, I'll try.

comment:9 in reply to:  8 Changed 7 years ago by karsten

Status: needs_reviewneeds_revision

Replying to gsathya:

Done. https://github.com/gsathya/compass/compare/bug_6677

Looks good. Merged and deployed. Thanks!

Googling turned up with this - https://forrst-production.s3.amazonaws.com/posts/snaps/136973/original.png?1332675932
It looks pretty, but I have no idea how to implement the CSS. I'll try playing around with it a bit.

Looks good.

Ok, I'll try.

Okay, leaving the ticket open and setting it to needs_revision.

comment:10 Changed 22 months ago by karsten

Severity: Normal
Summary: add a 'total' line at the bottom of the tableAdd a 'total' line at the bottom of the table

Capitalize summary.

comment:11 Changed 22 months ago by karsten

Owner: set to metrics-team
Status: needs_revisionassigned

comment:12 Changed 20 months ago by irl

Resolution: wontfix
Status: assignedclosed

The metrics team has put a goal of shutting down Compass in its roadmap and merging functionality with Relay Search (previously known as Atlas). This ticket is specific to Compass and as development on Compass has ceased, I am marking this ticket as wontfix.

See #23517 for information on the planned work to integrate Compass functionality into Relay Search.

Note: See TracTickets for help on using tickets.