Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#6678 closed enhancement (implemented)

add AS info to relay details page

Reported by: cypherpunks Owned by: hellais
Priority: Medium Milestone:
Component: Metrics/Relay Search Version:
Severity: Keywords:
Cc: karsten, nvivek16, hellais Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

When following the link from compass' page to atlas one "loses" the information regarding AS number and name. This information should be listed on the atlas router view page even if it is not part of the relay descriptor.

thanks!

Child Tickets

Attachments (1)

0001-Added-AS_name-and-AS_no-to-details-view.patch (2.1 KB) - added by nvivek16 7 years ago.
Added AS no and AS name to the details view

Download all attachments as: .zip

Change History (6)

comment:1 Changed 7 years ago by karsten

Sure, sounds doable and useful. Atlas already has the data, it's just not displayed. Should be very similar to how the country code is displayed. Want to submit a patch? :)

Speaking of country code, that could be changed to country name which is also available to Atlas right now.

Changed 7 years ago by nvivek16

Added AS no and AS name to the details view

comment:2 Changed 7 years ago by gsathya

Cc: karsten nvivek16 added
Status: newneeds_review

comment:3 Changed 7 years ago by karsten

Cc: hellais added

Looks good, thanks for the patch! I made some minor tweaks and pushed to branch task-6678 in my public repo. The tweaks should be squashed with the original patch when merging into master.

Arturo, please review and merge into master, or tell me to do the latter. Thanks!

comment:4 in reply to:  3 Changed 7 years ago by karsten

Resolution: implemented
Status: needs_reviewclosed

Replying to karsten:

Arturo, please review and merge into master, or tell me to do the latter. Thanks!

Merged and deployed. Closing.

comment:5 Changed 7 years ago by hellais

Awesome, thanks for handling this karsten.

Note: See TracTickets for help on using tickets.