compare_tor_addr_to_addr_policy assertion error
Occasionally, usually after tor fetches its directory microdescriptors or when I "wake" tor up after a long time of inactivity, I get the following error:
compare_tor_addr_to_addr_policy(): Bug: policies.c:716: compare_tor_addr_to_addr_policy: Assertion port != 0 failed; aborting.
After which tor exits. This didn't happen before (and I have been with this version of tor for a long time), though I've had this error twice in a week now, so thought to report it.
Trac:
Username: mr-4
Activity
changed milestone to %Tor: 0.2.2.x-final
Okay, looking through the code, we need fixes as follows:
- Replace the assertion with "if (port == 0) return ADDR_POLICY_REJECTED;"
- Maybe, reject any routerstatus with or_port == 0. At least authorities should do this.
A pseudonymous friend reports that there's a remote DOS opportunity against and by directory servers here, so we should treat this as pretty urgent.
Trac:
Milestone: Tor: 0.2.3.x-final to Tor: 0.2.2.x-final
Priority: normal to critical-
Replying to nickm:
That one is now in 0.2.2 and forward to master. I'll add another ticket for rejecting routerstatuses with a 0 orport.
This new ticket is #6716 (moved)
mentioned in issue #6716 (moved)
moved to tpo/core/tor#6690 (closed)
mentioned in issue tpo/core/tor#6716 (closed)