Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#6743 closed defect (fixed)

Don't set begindir_cutoff so low

Reported by: arma Owned by:
Priority: Medium Milestone: Tor: 0.2.3.x-final
Component: Core Tor/Tor Version:
Severity: Keywords: tor-client
Cc: mikeperry Actual Points:
Parent ID: #3443 Points:
Reviewer: Sponsor:


In #3443 we have problems where clients compute a low cbt, then end up giving up on a circuit while it's doing TLS handshakes, marking the relay down. This situation is especially bad when clients use bridges, since they give up on their bridges and then just sit there unwilling to connect to anything.

It is too late to do complex changes for 0.2.3. I wonder if it's not too late for some simple fixes though.

In particular, I'm thinking to let one-hop circuits use the full timeout, not half of it -- since the "half" heuristic makes even less sense when much of the circuit-building time is spent in the tls handshake.

-  SET_CUTOFF(begindir_cutoff, circ_times.timeout_ms / 2.0);
+  SET_CUTOFF(begindir_cutoff, circ_times.timeout_ms);

In #3443, Mike suggested that we just disable cbt for begindir requests. That sounds fine in theory too, but I think that's more something I'd want to test in 0.2.4 for a bit.

Child Tickets

Change History (6)

comment:1 Changed 8 years ago by arma

Cc: mikeperry added

comment:2 Changed 8 years ago by arma

Status: newneeds_review

See my bug6743 branch.

comment:3 Changed 8 years ago by nickm

I believe I like it? If mike approves, I say merge.

comment:4 Changed 8 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed


comment:5 Changed 8 years ago by nickm

Keywords: tor-client added

comment:6 Changed 8 years ago by nickm

Component: Tor ClientTor
Note: See TracTickets for help on using tickets.