Opened 8 years ago

Closed 7 years ago

#6753 closed defect (fixed)

chutney needs to set AlternateBridgeAuthority too

Reported by: arma Owned by: nickm
Priority: Medium Milestone:
Component: Core Tor/Chutney Version:
Severity: Keywords:
Cc: ln5 Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Since git commit 21c6c8485 (to Tor), Tor won't start if TestingTorNetwork is on, AlternateDirAuthority is set, but AlternateBridgeAuthority is not.

Child Tickets

Change History (3)

comment:1 Changed 8 years ago by ln5

It does if you run a BridgeAuthority.

chutney/networks/bridges (new since commit 3ecad7d8) does that.

We could add BridgeAuthority to chutney/networks/basic or we could
maybe make Chutney return DirServer lines instead of
AlternateDirAuthority lines if there is no bridge auth running.

I say maybe since I'm not sure if LocalNodeBuilder._getAltAuthLines()
knows what the network looks (will look?) like.

comment:2 in reply to:  1 Changed 7 years ago by sysrqb

Status: newneeds_review

Replying to ln5:

It does if you run a BridgeAuthority.

chutney/networks/bridges (new since commit 3ecad7d8) does that.

We could add BridgeAuthority to chutney/networks/basic or we could
maybe make Chutney return DirServer lines instead of
AlternateDirAuthority lines if there is no bridge auth running.

I say maybe since I'm not sure if LocalNodeBuilder._getAltAuthLines()
knows what the network looks (will look?) like.

The latter was my solution. LocalNodeBuilder._getAltAuthLines() does not currently know about the network so I decided to pass in a boolean value hasbridgeauth that simply tells it which option it should use (DirServer vs AlternateDirAuthority). This may not be the best solution, so suggestions are welcome.

Branch bug6753 in my repo.

comment:3 Changed 7 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

It's not pretty, but it doesn't make the current chutney code any *worse*. Merged it. :)

Note: See TracTickets for help on using tickets.